Repository navigation
fix(h5p-author): sync:skill builds the player's plan first (#120) - #121
Merged
Merged
Conversation
sync-skill.mjs imports lib/author.mjs, which since #106 imports the player's ./plan, dist/h5p-plan.js. The Library pack workflow runs sync:skill on a fresh checkout before pnpm build, and it stopped there with ERR_MODULE_NOT_FOUND. The script builds the plan first now, as the package's test:unit does, so it works on any fresh clone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120.
What
sync:skillinpackages/author/package.jsonnow builds the player'sdist/h5p-plan.js(build:plan) before it runs, as the same package'stest:unitdoes. So it works on a fresh checkout, which is what the Library pack workflow runs it on.sync:skillamong the scripts that runbuild-plan.The workflow could instead run
sync:skillafterpnpm build. Fixing the script covers that and a fresh clone too, whereapps/skills' test tells a contributor to run the command when a type file is out of date.Checked
pnpm libraries, then the workflow step's own script up tosync:skill, cut fromlibraries.yml.ERR_MODULE_NOT_FOUND.parts/index.json, and each library's line inlibraries.txtchanged with them (Library pack refresh rewrites parts whose libraries did not change #116).sync:skillbuiltdist/h5p-plan.jsand wrote two type files, H5P.MemoryGame.md and H5P.QuestionSet.md.libraries.txtand the pack'spackage.json(1.0.1).sync:skillwrites no file.After merging
Run the Library pack workflow again (
gh workflow run libraries.yml, or from the Actions tab). #111 then holds the five updated libraries alone.🤖 Generated with Claude Code