Skip to content

fix(h5p-author): sync:skill builds the player's plan first (#120) - #121

Merged
alekswebnet merged 1 commit into
mainfrom
fix/sync-skill-plan
Nov 3, 2026
Merged

alekswebnet merged 1 commit into
mainfrom
fix/sync-skill-plan

Conversation

@alekswebnet

Copy link
Copy Markdown
Contributor

Closes #120.

What

  • sync:skill in packages/author/package.json now builds the player's dist/h5p-plan.js (build:plan) before it runs, as the same package's test:unit does. So it works on a fresh checkout, which is what the Library pack workflow runs it on.
  • AGENTS.md names sync:skill among the scripts that run build-plan.

The workflow could instead run sync:skill after pnpm build. Fixing the script covers that and a fresh clone too, where apps/skills' test tells a contributor to run the command when a type file is out of date.

Checked

  • The failure, reproduced:
    • In a fresh worktree of main (4340cdc), with nothing built: pnpm libraries, then the workflow step's own script up to sync:skill, cut from libraries.yml.
    • It stopped with the run's ERR_MODULE_NOT_FOUND.
    • Both of the step's guards passed on the way: the parts of the five updated libraries changed, with parts/index.json, and each library's line in libraries.txt changed with them (Library pack refresh rewrites parts whose libraries did not change #116).
  • The fix:
    • Run on the same tree, sync:skill built dist/h5p-plan.js and wrote two type files, H5P.MemoryGame.md and H5P.QuestionSet.md.
    • Both files are byte for byte the ones in Library pack 1.0.1 #111. So are libraries.txt and the pack's package.json (1.0.1).
    • On main's own pack, sync:skill writes no file.

After merging

Run the Library pack workflow again (gh workflow run libraries.yml, or from the Actions tab). #111 then holds the five updated libraries alone.

🤖 Generated with Claude Code

sync-skill.mjs imports lib/author.mjs, which since #106 imports the
player's ./plan, dist/h5p-plan.js. The Library pack workflow runs
sync:skill on a fresh checkout before pnpm build, and it stopped there
with ERR_MODULE_NOT_FOUND. The script builds the plan first now, as the
package's test:unit does, so it works on any fresh clone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alekswebnet alekswebnet self-assigned this Nov 3, 2026
@alekswebnet
alekswebnet merged commit 397f7f4 into main Nov 3, 2026
8 checks passed
@alekswebnet
alekswebnet deleted the fix/sync-skill-plan branch November 3, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library pack workflow fails at sync:skill: the player's dist/h5p-plan.js is not built yet

1 participant