Skip to content

fix: minimatch 11 under @vscode/vsce, for Dependabot alert #4 (#104) - #105

Merged
alekswebnet merged 1 commit into
mainfrom
fix/minimatch-11
Nov 1, 2026
Merged

alekswebnet merged 1 commit into
mainfrom
fix/minimatch-11

Conversation

@alekswebnet

Copy link
Copy Markdown
Contributor

Closes #104, and with it Dependabot alert #4 once it reaches main.

minimatch 10.2.6 has GHSA-g3hv-75wg-m249 (medium), and 11.0.1 is the first fixed version. It is in the repository only under @vscode/vsce: directly, and through ovsx. Both vsce 4.0.0 and the latest, 4.1.0, take ^10.2.6, so this adds a pnpm override, '@vscode/vsce>minimatch': ^11.0.1, beside the one for alert #3. The lockfile now resolves minimatch 11.0.3, and 10.2.6 is gone.

vsce calls only minimatch(path, pattern, { dot: true }), to apply .vscodeignore. minimatch 11 keeps that function. What 11 removed (makeRe, Minimatch#regexp, the AST class, debug) is never called. The comment in pnpm-workspace.yaml says when to remove the override: once vsce takes minimatch 11.

Check

I ran pnpm --filter h5p-preview package before and after the change. Both produced h5p-preview-0.3.0.vsix with the same 141 entries, and every entry has the same name, size and CRC-32.

🤖 Generated with Claude Code

vsce 4.0.0, and 4.1.0 too, takes minimatch ^10.2.6, and no 10 fixes
GHSA-g3hv-75wg-m249: 11.0.1 is the first. vsce calls only minimatch()
itself, to apply .vscodeignore, which 11 keeps. A pnpm override forces
11 under vsce, as for alert #3. With it, `vsce package` writes the same
.vsix: 141 entries with the same names, sizes and CRCs.

Closes #104

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alekswebnet
alekswebnet merged commit 94bd746 into main Nov 1, 2026
8 checks passed
@alekswebnet
alekswebnet deleted the fix/minimatch-11 branch November 3, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependabot #4: minimatch below 11.0.1 under @vscode/vsce

1 participant