Repository navigation
fix: minimatch 11 under @vscode/vsce, for Dependabot alert #4 (#104) - #105
Merged
Merged
Conversation
vsce 4.0.0, and 4.1.0 too, takes minimatch ^10.2.6, and no 10 fixes GHSA-g3hv-75wg-m249: 11.0.1 is the first. vsce calls only minimatch() itself, to apply .vscodeignore, which 11 keeps. A pnpm override forces 11 under vsce, as for alert #3. With it, `vsce package` writes the same .vsix: 141 entries with the same names, sizes and CRCs. Closes #104 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104, and with it Dependabot alert #4 once it reaches
main.minimatch10.2.6 has GHSA-g3hv-75wg-m249 (medium), and 11.0.1 is the first fixed version. It is in the repository only under@vscode/vsce: directly, and throughovsx. Both vsce 4.0.0 and the latest, 4.1.0, take^10.2.6, so this adds a pnpm override,'@vscode/vsce>minimatch': ^11.0.1, beside the one for alert #3. The lockfile now resolves minimatch 11.0.3, and 10.2.6 is gone.vsce calls only
minimatch(path, pattern, { dot: true }), to apply.vscodeignore. minimatch 11 keeps that function. What 11 removed (makeRe,Minimatch#regexp, theASTclass,debug) is never called. The comment inpnpm-workspace.yamlsays when to remove the override: once vsce takes minimatch 11.Check
I ran
pnpm --filter h5p-preview packagebefore and after the change. Both producedh5p-preview-0.3.0.vsixwith the same 141 entries, and every entry has the same name, size and CRC-32.🤖 Generated with Claude Code