Repository navigation
fix(h5p-author): the skill writes every content type from its type file (#102) - #103
Merged
Merged
Conversation
…le (#102) The quiz format's two references and its examples leave the skill: a quiz is written from the H5P.QuestionSet and H5P.MultiChoice type files, which cover what the format did. The examples are now fixtures in packages/author/tests/fixtures, since the package still builds the format for sources written for the first skill. AGENTS.md records this, and the single verifier run of b02b13a. Closes #102 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102.
The h5p-author skill drops the references from its quiz-only first version. Every content type is now written from its type file.
references/quiz-format.mdandreferences/scenario-quiz.mdgo, with the line inSKILL.mdand the link inauthoring.mdthat led to them. A quiz uses the H5P.QuestionSet and H5P.MultiChoice type files, which already cover feedback on each answer, the pass mark and its messages, titles, and Question Set's result message and English navigation.assets/quiz.jsonandassets/phishing-scenarios.jsonmove topackages/author/tests/fixtures/. The package still builds the quiz format (lib/quiz.mjs), so a source written for the first skill keeps working. The author tests, the skills' verify test and the playback test read the examples from the new folder.The skill is now
SKILL.md,LICENSE,references/authoring.mdand the type files. Nothing published changes.Checks
pnpm --filter @missing-elements/h5p-author test: 103 passed.pnpm --filter @missing-elements/h5p-skills test: 73 passed. Every type file's example and every quiz-format source is built and played trusted and untrusted, and the playback test passes.typecheck.🤖 Generated with Claude Code