Skip to content

pack.test.ts: the early-boot test wins its race by a third of a second, and lost it on main in Firefox #75

Closed

Description

@alekswebnet

pack.test.ts > "attaches the parts while a download from a host without Range is under way" failed in Firefox on main after #74 merged (run 39930027264):

AssertionError: expected [ 'probing', 'downloading', …(2) ] to deeply equal [ 'probing', 'downloading', 'ready' ]
+   "indexing",

The test paces needs-dependency.h5p, 265,685 bytes, at 131,072 bytes per second, so the download takes about 2.0 s. It expects the frame to boot from the forward index before then, with the pack's parts attached. In the last ten Firefox runs that passed, the test reached ready at 1.66 to 1.93 s, so it won by a third of a second at most. On a slower runner the early boot came after the download had ended, and the load went through indexing, as a whole download does. The PR run of the same commit passed 8 minutes earlier.

libraries.test.ts paces the same fixture at the same rate, but its assertions hold on either path.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions