You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
h5p-author: a ">" inside a quoted attribute builds into markup that hides what follows #222
after / next paragraph, both inside the link; the word "link" is gone
The build's markup check (markupText) reads tags as H5P's content check splits them, ending a tag at its first >. So it takes <a title="a> for the tag and escapes the real closing > as a lone one. A browser reads the quoted value whole and keeps reading the tag until the next >, the one in </a>. The link's text is lost, the <a> is never closed, and what follows becomes the link. Written title="a>b", the same markup shows as written.
Fix: refuse it by name, as the build refuses the other markup a platform would change: "write > for a > inside an attribute". A quote left open in a tag (<a title="x>) is the same case.
Found in the self-review of #221. It has been on main since the markup check was written.
Activity
fix(author): read a tag's attributes as a browser does, so a quote in…
Merge pull request #223 from missing-elements/fix/author-markup-open-…