Skip to content

SCORM zip and page: six points from the self-review of #139 and #140 #142

Closed

Description

@alekswebnet

A self-review of #139 and #140 after they merged found nothing blocking and six small points. One PR for all six.

The zip and the bridge (#140)

  1. A 2004 interaction's pattern and response are written without a type. For an answered statement whose interactionType is not one the bridge maps, scorm.js still writes cmi.interactions.n.correct_responses.0.pattern and cmi.interactions.n.learner_response. SCORM 2004 asks for type first and answers error 408 otherwise. All ten of H5P's types map in 2004, so only a statement without one hits this; the two writes should be skipped in 2004 when there is no type.
  2. The command's summary prints the mark as typed. --pass-mark 66.666 says "pass mark 66.666" while the zip holds 66.67. The result of buildScorm should carry the options as written (passMark, completionScore), as it carries scormVersion, and the summary should name those.
  3. The no-score checks are described without their mark. design/scorm.md and the body of SCORM 2004, a pass mark and completion as 100, as options #140 say a finish with no score "recorded 100 and passed in both" LMSs. The zips used there also carried a pass mark of 80; without one, completion as 100 gives completed in 1.2 and leaves success unknown in 2004, as the tests assert. Say so.

The page and the planner (#139)

  1. planScormInPage({ title }) ignores the title. The plan's title and a write() with no title fall back to the package's, while buildScormInPage with the same options applies it, and the README says the plan takes the same options. The title given to the plan should be the plan's, and write's default.
  2. write hashes the package on every call. The build stamp (sha256Hex of the whole file) is computed inside write, so a zip written again under another title reads and hashes the package again. The file never changes between writes: hash once, on the first write.
  3. Files dropped during a build vanish. add returns while the page is busy, without a word, and the drop zone is the whole page. Rows can be added during a build; they are read and wait for the next Build.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions