Skip to content

typo and case sensible #28

Description

@ncou

Hi,

Very nice lib, i looked at the code and it seems to me there is :

  1. a typo error in a comment for the regex explanation line 154 :

[^\s()<>]+ # Run of non-space, non-()<>
the "-" character is no more in the regex, so it should be removed from the comment.

  1. line 167 there is a check to verify if there is a need to add an "http" value in the link. I think you should add an "~i" value to avoid the case sensitive problem. For example if someone add a text "hTTp://www.xxx.xxx" the http will be added because your regex is case sensitive.

Keepup the good work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions