Avoid mutating LLM prompt dataframes#12440
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__mdb_promptcolumn into the caller DataFrame__mdb_promptcolumnWhy
get_completed_promptsis used by LLM/model handlers to render prompt templates. The helper previously mutated its input DataFrame by adding__mdb_prompt, which could leak internal state into downstream code or overwrite a real user column with the same name.Validation
.test-venv/bin/python -m pytest tests/unit/various/test_llm_utils.py -q->2 passed in 13.09s/tmp/mindsdb-ruff-venv/bin/ruff check mindsdb/integrations/libs/llm/utils.py tests/unit/various/test_llm_utils.py->All checks passed!