Skip to content

[ENG-3419] Send the selected reasoning effort to cloud turns - #671

Open
tino097 wants to merge 8 commits into
stagingfrom
tino097/eng-3419-cloud-turns-honor-the-reasoning-effort-the-user-selected
Open

tino097 wants to merge 8 commits into
stagingfrom
tino097/eng-3419-cloud-turns-honor-the-reasoning-effort-the-user-selected

Conversation

@tino097

@tino097 tino097 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

https://linear.app/mindsdb/issue/ENG-3419

What changed

  • Preserve the selected reasoning effort in remote turn jobs: the composer's reasoning_effort, which the remote path dropped, now reaches the queued job params; it is left out when unset
  • Test that the selected effort reaches the queued job on every turn: tests only
  • Leave an effort the model does not offer out of the queued job: when the org's model catalog is cached, a level the model does not advertise is dropped, so the turn runs at the default
  • Import the producer at the top of the remote backend tests: tests only
  • Read the org catalog through one helper so the producer and fetch share a cache key: the producer can no longer miss the cache through a drifted URL
  • Drop the stub-only effort test the end-to-end queue test already covers: tests only
  • Say in the job builder that the server already filters the effort: comment only
  • Drop the second stub-only effort test the end-to-end queue test covers: tests only

Notes for the reviewer

  • The filter is a first check, not the only one. Without a cached catalog (a fresh replica) the effort is sent on, and the pod falls back to its configured effort if the provider refuses it ([ENG-3419] Honor the selected reasoning effort in cloud turns anton#568).
  • Org scoped. The catalog read is keyed by org and user, the same entry the composer's model list fills.
  • No frontend change. cowork/src/renderer/cowork/api.js already sends reasoning_effort.

Ships with

Checks

Check Observed result
make test/unit (macOS) 6373 passed, 2 skipped, 1 failed + 5 errors; the same tests fail on staging (macOS only)
uv run pytest tests/test_responses_remote_backend.py tests/turnqueue/test_producer.py after the last commit 186 passed
New filter tests run against the prior producer fail as expected

Linux CI is the authoritative unit run.

🤖 Generated with Claude Code

tino097 and others added 8 commits October 13, 2026 15:25
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…re a cache key.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T15:09:01.912664Z 4b1776f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

No PR environment for this pull request

Add the deploy label and push to create one. It is torn down when the label is removed or the PR closes, so any URL you saw here earlier is gone.

Updated on every push to this PR.

@lucas-koontz
lucas-koontz force-pushed the tino097/eng-3419-cloud-turns-honor-the-reasoning-effort-the-user-selected branch from 4b1776f to 94b2721 Compare October 18, 2026 05:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant