fix(channel): resolve .exe path from npm .cmd shim on Windows#352
Open
wsolarq11 wants to merge 1 commit into
Open
fix(channel): resolve .exe path from npm .cmd shim on Windows#352wsolarq11 wants to merge 1 commit into
wsolarq11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #348
spawn("claude")fails on Windows because npm puts only a.cmdshim in PATH, not the real.exe. Node.js >=18.20.2 (CVE-2024-27980) blocks implicit.cmdexecution withoutshell: true. Usingshell: truewould reintroduce the injection vector -- the args carry--append-system-promptcontent.Instead, parse the npm-generated
.cmdshim to find the real.exe, then spawn it directly. No shell, no injection risk.Change:
packages/cli/src/commands/channel/supervisor.ts+
resolveProviderPath()utility2 lines modified at the spawn call
0 import changes, 0 new dependencies
No effect on macOS/Linux (
process.platformguard)Fixes both
claudeandcodexadaptersFalls back to original
providerif resolution fails