fix: pass fname and correct nodetype kwarg when reading weighted graphs - #8
Open
JOhnsonKC201 wants to merge 1 commit into
Open
fix: pass fname and correct nodetype kwarg when reading weighted graphs#8JOhnsonKC201 wants to merge 1 commit into
JOhnsonKC201 wants to merge 1 commit into
Conversation
read_net's weighted branch called nx.read_edgelist(inodetype=int, ...), which omits the required edgelist path and passes an argument read_edgelist does not accept. Any run with --weighted aborts immediately with 'TypeError: read_edgelist() got an unexpected keyword argument inodetype' before any embedding work happens. Pass fname as the path and use nodetype=int, matching the unweighted branch just below. Closes mims-harvard#5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
read_net's weighted branch calls:This never passes the edgelist path and hands
read_edgelistaninodetypekeyword it doesn't accept, so any run with--weighteddies immediately with:before any embedding work happens. The fix passes
fnameas the path and usesnodetype=int, matching the unweighted branch right below it. Unweighted runs are unaffected.@marinkaz offered to merge a fix for this in #5; #6 made the same change but was auto-closed when the contributor's fork was removed, so this picks it back up.