Bump to 1.2.0 and add Core/UI/Commands/Shard/Minimap/Migration module split#3
Bump to 1.2.0 and add Core/UI/Commands/Shard/Minimap/Migration module split#3milestorme wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0f8d0c78b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| msg = (msg or ""):lower() | ||
|
|
||
| if msg == "pause" then | ||
| (AJD.Core and AJD.Core.TogglePause and AJD.Core.TogglePause() or AJD.TogglePause()) |
There was a problem hiding this comment.
Replace
and/or dispatch that double-calls command handlers
The dispatch expression here executes both branches in normal builds because AJD.Core.TogglePause() (and the analogous UI/minimap wrappers) returns nil; in Lua, a and b() or c() evaluates c() when b() is falsy. With Core.lua loaded from the TOC, /ajd pause toggles twice (net no state change) and /ajd toggle also cancels itself, so key slash commands appear broken. Please switch to an explicit if ... then ... else ... end dispatch so only one handler runs.
Useful? React with 👍 / 👎.
Motivation
resume/statusactions and exporting core actions for use by a dedicated command router.Description
AutoJunkDestroyer_Commands.luatoCommands.luaand added a slash-command router that delegates into a runtime table at_G.AutoJunkDestroyerRuntime.Core.lua,UI.lua,Minimap.lua,Shard.lua, andMigration.lua, and wired them to call into the runtime exports where appropriate.AutoJunkDestroyer.luato expose runtime exports (AJD.Print,AJD.SetThreshold,AJD.TogglePause,AJD.Resume,AJD.PrintStatus,AJD.HandleButtonCommand,AJD.HandleMinimapCommand, etc.), hardened the AceDB pre-logout wrapper with a compatibility guard and debug path, and removed a redundantPrintexpression.1.2.0and include the new module files, added localized keys across allLocales/*.luafiles for parity, and added CI/scripts:scripts/check_locale_parity.py,scripts/check_lua_syntax.sh, and.github/workflows/ci.yml.Testing
./scripts/check_locale_parity.pywhich returnedLocale key parity OK across 11 files(success).python -m py_compile scripts/check_locale_parity.pywhich completed successfully (syntax OK for the parity script)../scripts/check_lua_syntax.shin this environment and it could not run becauseluacis not installed (CI workflow will runluac -pon GitHub Actions).Codex Task