Conversation
Removed the Schwab API client as it only provided historical prices, which yfinance already handles adequately. This simplifies the codebase and removes the need for Schwab API credentials. Changes: - Removed backend/schwab_client.py - Removed schwab-py from requirements.txt - Updated app.py to use only yfinance for historical prices - Removed Schwab-related tests (3 test functions) - Updated README.md to remove Schwab API setup instructions - Updated .env.example to remove Schwab configuration The application now uses: - SEC EDGAR for fundamental data (EPS, revenue) - yfinance for all historical and current price data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the Schwab API client as it only provided historical prices, which yfinance already handles adequately. This simplifies the codebase and removes the need for Schwab API credentials.
Changes:
The application now uses: