Fix: Add caching for _ZvecClient._load_collection_entries#70
Open
mikewaters wants to merge 1 commit into
Open
Conversation
The _load_collection_entries method was reading and JSON-parsing the full index file from disk on every invocation. During _PayloadEmbeddingIdentityStrategy.query, get_embedding_identities() triggers one read, and each subsequent per-identity _query_zvec() call triggers another. With K stored identities this resulted in K+1 full file reads and parses per search operation. Added file modification time based caching to avoid redundant I/O and JSON parsing. The cache is invalidated when the file's mtime changes, ensuring data consistency when the file is updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _load_collection_entries method was reading and JSON-parsing the full index file from disk on every invocation. During _PayloadEmbeddingIdentityStrategy.query, get_embedding_identities() triggers one read, and each subsequent per-identity _query_zvec() call triggers another. With K stored identities this resulted in K+1 full file reads and parses per search operation.
Added file modification time based caching to avoid redundant I/O and JSON parsing. The cache is invalidated when the file's mtime changes, ensuring data consistency when the file is updated.