Repository navigation
fix: unbreak nightly fuzzer after setup-rust-toolchain v2 bump - #328
Merged
Merged
Conversation
setup-rust-toolchain v2 enforces warning-free builds via cargo's
build.warnings config (CARGO_BUILD_WARNINGS=deny) instead of
RUSTFLAGS="-D warnings". Unlike RUSTFLAGS, that also denies cargo
*manifest* lints, which broke the fuzzer job:
error: warnings are denied by `build.warnings` configuration
Nightly cargo emits cargo::non_kebab_case_bins for the fuzz_target_1 and
fuzz_round_trip binaries. Those names cannot be changed: cargo-fuzz
requires the target name to match the fuzz_targets/ file stem. Only the
fuzzer job failed because it is the sole job on nightly; the lints do not
exist in the pinned 1.94.0 stable used elsewhere.
Set build-warnings: warn on that job. Nightly cargo adds manifest lints
continuously and the job exists to find crashes; lint hygiene stays
enforced by the pinned-stable clippy job.
Also drop the explicit package.readme key, which cargo infers and newer
cargo flags via cargo::manual_readme, to keep the stable jobs from
breaking the same way later. Packaging is unaffected: the packaged
manifest still contains readme = "README.md".
Bump to 1.1.0 and add the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-rust-toolchain v2 enforces warning-free builds via cargo's build.warnings config (CARGO_BUILD_WARNINGS=deny) instead of RUSTFLAGS="-D warnings". Unlike RUSTFLAGS, that also denies cargo manifest lints, which broke the fuzzer job:
Nightly cargo emits cargo::non_kebab_case_bins for the fuzz_target_1 and fuzz_round_trip binaries. Those names cannot be changed: cargo-fuzz requires the target name to match the fuzz_targets/ file stem. Only the fuzzer job failed because it is the sole job on nightly; the lints do not exist in the pinned 1.94.0 stable used elsewhere.
Set build-warnings: warn on that job. Nightly cargo adds manifest lints continuously and the job exists to find crashes; lint hygiene stays enforced by the pinned-stable clippy job.
Also drop the explicit package.readme key, which cargo infers and newer cargo flags via cargo::manual_readme, to keep the stable jobs from breaking the same way later. Packaging is unaffected: the packaged manifest still contains readme = "README.md".
Bump to 1.1.0 and add the release notes.