Conversation
The Work pane rendered two layouts of the same task data: a full-width table when nothing was selected, and a master-detail list once a task was selected. The table duplicated the master list's Status/Sort/Search controls, so it was only a second, heavier way to browse the same receipts. Always present the master-detail "Work receipts" list: - workLayoutMode no longer returns .table; with no selection it yields .split (wide) or .list (compact). WorkLayoutMode.table -> .list. - Delete WorkTablePage, WorkTableRow, WorkAccessibleTableRow (~730 lines); the status tab bar and work.table* identifiers lived only there. All of its filtering is preserved by the master list's own controls. - Drop the .table snapshot state, the window-work-table render, the eight work-table-*.png goldens, and their test expectations. - Refresh stale "table" comments and the Tests snapshot matrix. swift build + swift test: 316 passed, 0 failures (6 host-gated visual skips). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013w9bhGCPP2g37g4xiehwDV
# Conflicts: # apps/agentacct/Sources/agentacct/WorkPane.swift
With the full-width table gone, the Sessions surface with nothing selected shows the master list beside an empty record area. Main re-recorded the empty, loading and list-error references against the table after this branch was cut, so they are recorded again here on the canonical renderer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
|
Merged 🤖 Generated with Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The macOS app's Work pane rendered two layouts of the same task data:
The table only duplicated the master list's own Status / Sort / Search controls — a second, heavier way to browse the same receipts. This removes it so the Work pane always presents the master–detail list.
Changes
WorkPane.swift—workLayoutMode(...)no longer returns.table; with no selection it yields.split(wide) or.list(compact).WorkLayoutMode.table→.list. DeletedWorkTablePage,WorkTableRow,WorkAccessibleTableRow(~730 lines) — the status tab bar andwork.table*identifiers lived only there. All of the table's filtering is preserved bymasterControls.WorkSnapshotHarness.swift— dropped the.tablesnapshot state.SnapshotRunner.swift— removed thewindow-work-tablerender.workLayoutModeassertions, removed the 8work-table-*expectations, repointed one state-difference check, and deleted the 8work-table-*.pnggoldens.Tests/README.mdsnapshot matrix.Net: +49 / −802 lines, plus 8 removed reference images.
Verification
git grepfor table-page references → clean.swift build✓swift test→ 316 passed, 0 failures (6 host-gated visual-regression tests skipped). The deterministictestRendersEveryWorkReviewConfigurationDeterministicallyrenders the realWorkPane/MainWindowand passes.Note
Based on
main, where the kept master–detail is titled "Work receipts". It does not include the newer Activity-timeline canvas / "Focus timeline" that live only ondesign/native-recording-experience; this table removal is independent of that work.🤖 Generated with Claude Code
https://claude.ai/code/session_013w9bhGCPP2g37g4xiehwDV