feat: K8S KYAML output format support #2560
Conversation
Reference: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/5295-kyaml/README.md Co-authored-by: Codex <codex@openai.com> Generated-with: OpenAI Codex CLI (partial) Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
| edwinjhlee | ||
| flox | ||
| flox | ||
| unlabeled |
There was a problem hiding this comment.
unlabelled (double l) for UK english, which this project's locale
| } | ||
|
|
||
| for _, s := range scenarios { | ||
| testKYamlScenario(t, s) |
There was a problem hiding this comment.
Add 'documentScenarios' here so we can generate docs based off these tests :)
There was a problem hiding this comment.
You'll also need to add a header/kyaml.md (see the other formats for examples 👍🏼 )
|
|
||
| .PHONY: build/dev | ||
| build/dev: test *.go | ||
| build/dev: *.go |
There was a problem hiding this comment.
will revert for now; but I was finding it hindered rapid development. I do want to test - but the slow test targets in the Makefile shouldn't be a pre-req for a quick development build.
| return nil | ||
| } | ||
|
|
||
| func (ke *kyamlEncoder) PrintLeadingContent(writer io.Writer, content string) error { |
There was a problem hiding this comment.
is this the same logic as the yaml encoder? Could it be pulled out into a common function?
| " ],\n" + | ||
| " # trailing\n" + | ||
| "}\n", | ||
| }, |
There was a problem hiding this comment.
good to add some more tests in here, plain scalars, maybe converting from yaml to kyaml to show the difference (particularly when you add documentScenarios in.
|
Nice work codex + @robbat2 - couple of comments to resolve |
|
Oh other thing to add are the compiler directives to allow for minimal builds (e..g |
2 participants
Reference: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/5295-kyaml/README.md
Co-authored-by: Codex codex@openai.com
Generated-with: OpenAI Codex CLI (partial)
Signed-off-by: Robin H. Johnson rjohnson@coreweave.com