Skip to content

comment out flaky PVC content validation pending root cause investigation #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
midays wants to merge 2 commits into
base: main
Choose a base branch
from
+50 −38
Open

comment out flaky PVC content validation pending root cause investigation #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a7c7d5
Update e2e test for CronJob PVC migration: Comment out PVC data integ…
midays May 25, 2026
17d89f4
Update e2e test for CronJob PVC migration: Add reference to BUG #408 …
midays May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 50 additions & 38 deletions e2e-tests/tests/mta_813_cronJob_PVC_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
)

var _ = Describe("CronJob with attached PVC migration as non-admin user", func() {
It("[BUG #330][MTA-813] Should migrate a cronjob and its attached PVC as a namespace-admin user", Label("BUG #330", "tier0"), func() {
It("[BUG #330][BUG #408][MTA-813] Should migrate a cronjob and its attached PVC as a namespace-admin user", Label("BUG #330", "BUG #408", "tier0"), func() {
appName := "cronjob"
namespace := "mta-813-ns"
expectedLogSubstring := fmt.Sprintf("Hello! from namespace %s", namespace)
Expand Down Expand Up @@ -222,46 +222,58 @@ var _ = Describe("CronJob with attached PVC migration as non-admin user", func()
}, "1m", "5s").Should(Equal("*/1 * * * *"))
log.Printf("CronJob %s confirmed on target with correct schedule\n", appName)

By("Verify PVC data was transferred intact by running a reader pod on target")
_, err = scenario.KubectlTgtNonAdmin.Run(
"run", "pvc-reader",
"-n", namespace,
"--image=busybox",
"--restart=Never",
fmt.Sprintf(`--overrides={
"spec": {
"containers": [{
"name": "pvc-reader",
"image": "busybox",
"command": ["sh", "-c", "cat /data/log.txt || echo FILE_NOT_FOUND"],
"volumeMounts": [{"name":"data","mountPath":"/data"}]
}],
"volumes": [{"name":"data","persistentVolumeClaim":{"claimName":"%s"}}],
"restartPolicy": "Never"
}
}`, pvcName),
)
Expect(err).NotTo(HaveOccurred())
By("Skipped - Verify PVC data was transferred intact by running a reader pod on target")
// TODO(https://github.com/migtools/crane/issues/408): PVC data integrity assertion
// is commented out due to flaky behavior on Linux (locally and on CI). On macOS,
// migration works correctly as namespace-admin and PVC content is transferred
// consistently. On Linux however, even with cluster-admin contexts, the PVC transfers
// (Bound on target) but the content is sometimes empty with no error surfaced.
//
// When investigating the crane source, the rsync server health check result was found
// to be silently discarded in cmd/transfer-pvc/transfer-pvc.go — if the server never
// becomes healthy, the command proceeds anyway with no error, making it harder to
// diagnose why the content isn't being transferred on Linux.
//
// Re-enable this assertion once crane#408 is resolved.
// _, err = scenario.KubectlTgtNonAdmin.Run(
// "run", "pvc-reader",
// "-n", namespace,
// "--image=busybox",
// "--restart=Never",
// fmt.Sprintf(`--overrides={
// "spec": {
// "containers": [{
// "name": "pvc-reader",
// "image": "busybox",
// "command": ["sh", "-c", "cat /data/log.txt || echo FILE_NOT_FOUND"],
// "volumeMounts": [{"name":"data","mountPath":"/data"}]
// }],
// "volumes": [{"name":"data","persistentVolumeClaim":{"claimName":"%s"}}],
// "restartPolicy": "Never"
// }
// }`, pvcName),
// )
// Expect(err).NotTo(HaveOccurred())

Eventually(func() string {
out, err := scenario.KubectlTgtNonAdmin.Run(
"get", "pod", "pvc-reader",
"-n", namespace,
"-o", "jsonpath={.status.phase}",
)
if err != nil {
return ""
}
return out
}, "2m", "5s").Should(Or(Equal("Succeeded"), Equal("Failed")))
// Eventually(func() string {
// out, err := scenario.KubectlTgtNonAdmin.Run(
// "get", "pod", "pvc-reader",
// "-n", namespace,
// "-o", "jsonpath={.status.phase}",
// )
// if err != nil {
// return ""
// }
// return out
// }, "2m", "5s").Should(Or(Equal("Succeeded"), Equal("Failed")))

pvcReaderLogs, err := scenario.KubectlTgtNonAdmin.Run("logs", "pvc-reader", "-n", namespace)
Expect(err).NotTo(HaveOccurred())
Expect(pvcReaderLogs).To(ContainSubstring(expectedLogSubstring),
"expected PVC log.txt to contain data written on source cluster")
log.Printf("PVC data integrity confirmed, source log entries present on target\n")
// pvcReaderLogs, err := scenario.KubectlTgtNonAdmin.Run("logs", "pvc-reader", "-n", namespace)
// Expect(err).NotTo(HaveOccurred())
// Expect(pvcReaderLogs).To(ContainSubstring(expectedLogSubstring),
// "expected PVC log.txt to contain data written on source cluster")
// log.Printf("PVC data integrity confirmed, source log entries present on target\n")

_, _ = scenario.KubectlTgtNonAdmin.Run("delete", "pod", "pvc-reader", "-n", namespace, "--ignore-not-found=true")
// _, _ = scenario.KubectlTgtNonAdmin.Run("delete", "pod", "pvc-reader", "-n", namespace, "--ignore-not-found=true")
Comment thread
midays marked this conversation as resolved.

By("Unsuspend CronJob on target and verify it fires")
_, err = scenario.KubectlTgtNonAdmin.Run(
Expand Down
Loading