Repository navigation
Conversation
Replace the hard-coded plugin version with a development default that release builds override through Go linker flags. This keeps local builds identifiable as devel and makes the binary metadata match the release selected from the plugin index. Replace the release workflow with a verified, immutable release process. It validates the requested version, refuses to reuse existing tags, checks module tidiness, runs unit tests, and builds binaries for Linux, macOS, and Windows. The workflow checks that every generated binary contains the requested version and verifies the version reported by the Linux plugin metadata endpoint before publishing artifacts and checksums. Remove automatic updates to crane-plugins from the release workflow. Add an index entry only after the release artifacts have passed all checks. Update the README with the local development version behavior and a linker-flag build example. Fixes: migtools#35 Signed-off-by: Marek Aufart <maufart@redhat.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hard-coded plugin version with a development default that release builds override through Go linker flags. This keeps local builds identifiable as devel and makes the binary metadata match the release selected from the plugin index.
Replace the release workflow with a verified, immutable release process. It validates the requested version, refuses to reuse existing tags, checks module tidiness, runs unit tests, and builds binaries for Linux, macOS, and Windows. The workflow checks that every generated binary contains the requested version and verifies the version reported by the Linux plugin metadata endpoint before publishing artifacts and checksums.
Remove automatic updates to crane-plugins from the release workflow. Add an index entry only after the release artifacts have passed all checks. Update the README with the local development version behavior and a linker-flag build example.
Fixes: #35