Open
Conversation
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vyzo
reviewed
Apr 21, 2025
| "env") | ||
| $* | ||
| ;; | ||
| "check") |
Collaborator
There was a problem hiding this comment.
should we call this test?
Also, it needs to be documented.
Collaborator
Author
There was a problem hiding this comment.
Where should I document it?
Collaborator
There was a problem hiding this comment.
in the script help and also reference/dev/bootstrap.md.
Also in the contributing guidelines.
drewc
changed the title
vyzo
reviewed
Apr 21, 2025
| @@ -1,3 +1,5 @@ | |||
| gxtest = ./... | |||
Collaborator
There was a problem hiding this comment.
move this lower in the file?
It shouldnt be the first thing a reader sees.
Collaborator
|
just a small nit, other than that looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.