feat(1474): expose ledger-emitted events from the node#1487
Draft
m2ux wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose ledger-emitted events from the node so downstream consumers (notably the indexer) no longer have to re-execute transactions to reconstruct them.
🐛 Issue 📐 Engineering
Motivation
The node currently discards every event emitted by the ledger when processing a transaction (see
ledger/src/versions/common/api/ledger.rs). To recover this data, the indexer re-applies every transaction locally — duplicating compute the node has already done and creating a divergence risk between the node and any consumer that needs to know what actually happened in a block. Exposing these events from the node removes the duplication and gives every downstream service a single, trustworthy source of truth.The work package will also assess the network-traffic and architectural implications of publishing all events, as flagged on the originating issue, before settling on a publication mechanism.
Changes
Implementation (coming next):
ledger/src/versions/common/api/ledger.rsso events are propagated rather than discarded📌 Submission Checklist
🔱 Fork Strategy
🗹 TODO before merging