Skip to content

Use weights from recent benchmark#1482

Open
justinfrevert wants to merge 5 commits into
mainfrom
core-pallet-benchmarked-weights
Open

Use weights from recent benchmark#1482
justinfrevert wants to merge 5 commits into
mainfrom
core-pallet-benchmarked-weights

Conversation

@justinfrevert
Copy link
Copy Markdown
Contributor

@justinfrevert justinfrevert commented May 8, 2026

Overview

Integrates weights from recent benchmark run on validator spec machine.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

justinfrevert and others added 4 commits May 7, 2026 12:44
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
@justinfrevert justinfrevert changed the title Core pallet benchmarked weights Use weights from recent benchmark May 8, 2026
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
@justinfrevert justinfrevert marked this pull request as ready for review May 8, 2026 20:46
@justinfrevert justinfrevert requested a review from a team as a code owner May 8, 2026 20:46
Copy link
Copy Markdown
Contributor

@Klapeyron Klapeyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking if there will be additional value if we will benchmark with https://crates.io/crates/frame-omni-bencher.
Also side topic, while ago we added hwbench probe #1394 based on https://github.com/paritytech/polkadot-sdk/blob/master/substrate/utils/frame/benchmarking-cli/src/machine/reference_hardware.json & https://github.com/paritytech/polkadot-sdk/blob/bcd139f350ac253b4cc0409993e1d070c4bcc396/substrate/utils/frame/benchmarking-cli/src/machine/hardware.rs#L27, I am thinking if there will be also a value if we will create our own profile based on our own reference hardware

@@ -0,0 +1,380 @@
// This file is part of midnight-node.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have twice pallet_collective and pallet_membership for council and technical_committee separately, do we need both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants