Use weights from recent benchmark#1482
Conversation
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Klapeyron
left a comment
There was a problem hiding this comment.
I am thinking if there will be additional value if we will benchmark with https://crates.io/crates/frame-omni-bencher.
Also side topic, while ago we added hwbench probe #1394 based on https://github.com/paritytech/polkadot-sdk/blob/master/substrate/utils/frame/benchmarking-cli/src/machine/reference_hardware.json & https://github.com/paritytech/polkadot-sdk/blob/bcd139f350ac253b4cc0409993e1d070c4bcc396/substrate/utils/frame/benchmarking-cli/src/machine/hardware.rs#L27, I am thinking if there will be also a value if we will create our own profile based on our own reference hardware
| @@ -0,0 +1,380 @@ | |||
| // This file is part of midnight-node. | |||
There was a problem hiding this comment.
we have twice pallet_collective and pallet_membership for council and technical_committee separately, do we need both?
Overview
Integrates weights from recent benchmark run on validator spec machine.
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links