feat: add pre-approvals filter to c2m-bridge#1477
Open
LGLO wants to merge 2 commits into
Open
Conversation
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
LGLO
force-pushed
the
c-to-m-bridge-approvals
branch
from
d09925e to
5e12e55
Compare
Klapeyron
reviewed
May 11, 2026
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
Klapeyron
reviewed
May 11, 2026
| ) -> DispatchResult { | ||
| T::GovernanceOrigin::ensure_origin(origin)?; | ||
| for hash in hashes { | ||
| ApprovedMcTxHashes::<T>::insert(hash, ()); |
Contributor
There was a problem hiding this comment.
do we need some event for it here or this one during transfer is sufficient?
Contributor
Author
There was a problem hiding this comment.
We don't need events for Approved Tx addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
For some time the protocol bridge will remain restricted by adding pre-approvals mechanism.
Each Cardano transaction should be first approved by the governance - by adding Cardano Tx Hash to Approved set.
Then it should be submitted to Cardano.
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links
https://github.com/shieldedtech/midnight-c-to-m-protocol-bridge/issues/2