ci: verify every local-env validator reaches finality#1452
Merged
Conversation
Add a `verify-finality <network>` ts-node command that polls `chain_getFinalizedHead` on every validator's RPC and fails if any node hasn't finalized within the timeout. Wire it into the local-environment GitHub action between deploying the stack and running e2e tests. GRANDPA needs 2/3 quorum; if any validator is stuck or panicking finality stalls. Probing every node up-front surfaces that deterministically rather than letting downstream tests time out further along, and in particular catches regressions in the unified-storage nodes (4 and 5) which currently don't have dedicated coverage. Also extends `check-health.sh` with an optional `-f|--finalized` flag for shell parity; default behaviour unchanged. Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Avoids hard-coding, and adds support for non-local-env networks Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
justinfrevert
approved these changes
May 11, 2026
Contributor
justinfrevert
left a comment
There was a problem hiding this comment.
Nice. Might be nice to have the finality checks on other local env runs as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Recently, a PR was merged that broke finality for nodes 4 and 5 on local-env - but CI passed without issue.
This PR adds finality checks for all nodes on local env:
🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links