Skip to content

tools: two pre-review slots, a device-dir cache, and a claude that does not answer --version refused #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
midagedev wants to merge 10 commits into from
Closed

tools: two pre-review slots, a device-dir cache, and a claude that does not answer --version refused #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e4a11f8
tools: refuse a claude that does not answer --version, and skip pre-c…
midagedev Oct 14, 2026
3d4f9a8
tools: two pre-review slots, a device-dir cache, context time after t…
midagedev Oct 14, 2026
6420f20
tools: a waiting pre-review takes whichever slot frees
midagedev Oct 14, 2026
4f7f338
tools: post.py device runs under the stable toolchain
midagedev Oct 14, 2026
ba46eb4
tools/review/local.py: the older self-test namespaces carry no_pre_ch…
midagedev Oct 15, 2026
751d45d
tools/review/local.py: time the context with a fake clock, and leave …
midagedev Oct 15, 2026
855d7a3
tools/review/local.py: device_dirs requires the base sha
midagedev Oct 15, 2026
e84cf9b
tools/review/local.py: a stubbed review takes no flock slot
midagedev Oct 15, 2026
f65b82a
tools/review/local.py: name a busy slot wait, and say broken install …
midagedev Oct 15, 2026
f23040c
tools/review/local.py: a claude --version that prints nothing is a br…
midagedev Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/contrib/local-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ runs of the same binary scatter on one machine. *DSpark* is V4.1's draft model f
| Mac | `just mac-static [BASE]` | formatting, clippy and the build shapes `BASE`'s change touches check as x86_64 Linux, and every check script passes; no test or gate runs | the environment file the header of `tools/mac-check.sh` describes (section 2) |
| x86_64 or aarch64 Linux, with or without a card | `just contrib-check --tier t1` | T0, then the tests of every crate that reaches no card | the CUDA headers, libclang, numpy and PIL (section 2) |
| Linux with an NVIDIA card | `BLOOMERY_BOX_LOCAL=1 BLOOMERY_TIER=fixture just gate-<x>`, for each gate of your list | that gate passes on your card at the fixture tier | an environment file, the fixtures and the reference sets (sections 3 and 4) |
| Any machine with the `claude` CLI logged in | `just pre-review` before each push of a pull request branch | Shingler's reviewer, on your committed HEAD with the pull request review's own instructions, finds no must-fix (exit 0) and prints one pull-request body line with the full HEAD sha; exit 1 lists must-fix items; a base behind origin/main is refused by name (64) | `git`, `gh` for an incremental review of an open pull request and the slag ledger, a Claude login |
| Any machine with the `claude` CLI logged in | `just pre-review` before each push of a pull request branch | Shingler's reviewer, on your committed HEAD with the pull request review's own instructions, finds no must-fix (exit 0) and prints one pull-request body line with the full HEAD sha; exit 1 lists must-fix items; a base behind origin/main is refused by name (64) | `git`, `gh` for an incremental review of an open pull request and the slag ledger, `cargo` (`post.py device` runs `recipes.py pure-crates`), a Claude login |

Paste what each command printed into the pull request: for `contrib-check`, its header block, its unit lines and its
`DONE` line; for a gate, its summary lines and its exit code. Name the machine as `CONTRIBUTING.md` asks ("Pull requests
Expand Down
Loading
Loading