Skip to content

ref builders: failed git status is accepted as a clean source tree #265

Closed

Description

@github-actions

The hidden, nemotron and clefvis builders put git status inside a test's command substitution. A corrupt or unreadable Git index makes status exit 128 with empty stdout. The test then treats the tree as clean. rev-parse HEAD does not need that index, so the scripts can compile unchecked headers and record the commit as their provenance. Validation reproduced exit 0 after a status stub returned 128; the standalone assignment exited 128. Capture git status in a standalone assignment before testing its output; set -e then stops on failure.

Evidence (at the base of #242):

Filed by Shingler, the review bot, while reviewing #242; the defect is outside that pull request.

Activity

  1. added
    review-botFiled by the PR review bot: a defect found outside the reviewed pull request
    on Oct 15, 2026
  2. Burntgogi commented on Oct 15, 2026

    @Burntgogi
    Contributor

    Implemented together with #262 in PR #272, including qvis explicit fail() handling despite its intentional lack of errexit. A real corrupt Git index must yield exit 2, rc=2, and no configure/compile marker. All four builder regressions now pass; final focused check-emb2: 11 passed, 1 opt-in linked-dumper check skipped. Combined five-fix T0: 83 units, 0 red. No real CUDA oracle build is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    review-botFiled by the PR review bot: a defect found outside the reviewed pull request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions