You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ref builders: failed git status is accepted as a clean source tree #265
The hidden, nemotron and clefvis builders put git status inside a test's command substitution. A corrupt or unreadable Git index makes status exit 128 with empty stdout. The test then treats the tree as clean. rev-parse HEAD does not need that index, so the scripts can compile unchecked headers and record the commit as their provenance. Validation reproduced exit 0 after a status stub returned 128; the standalone assignment exited 128. Capture git status in a standalone assignment before testing its output; set -e then stops on failure.
Implemented together with #262 in PR #272, including qvis explicit fail() handling despite its intentional lack of errexit. A real corrupt Git index must yield exit 2, rc=2, and no configure/compile marker. All four builder regressions now pass; final focused check-emb2: 11 passed, 1 opt-in linked-dumper check skipped. Combined five-fix T0: 83 units, 0 red. No real CUDA oracle build is claimed.
Activity
Burntgogi commentedon Oct 15, 2026
Implemented together with #262 in PR #272, including qvis explicit fail() handling despite its intentional lack of errexit. A real corrupt Git index must yield exit 2, rc=2, and no configure/compile marker. All four builder regressions now pass; final focused check-emb2: 11 passed, 1 opt-in linked-dumper check skipped. Combined five-fix T0: 83 units, 0 red. No real CUDA oracle build is claimed.
ref: refuse failed source-tree status before oracle builds