Repository navigation
ref tools: hidden_ref accepts malformed numeric options #243
Description
In hidden_ref.cpp, -c bad is parsed by atoi as zero and then replaced with the prompt length at line 150. Likewise, -ngl bad becomes zero GPU layers and -t bad selects the default thread count. With otherwise valid arguments, invalid input runs inference and writes a completed reference set. Parse the entire integer with strtol, reject conversion and range errors by name, and use the checked conversion for every numeric option.
Evidence (at the base of #242):
Filed by Shingler, the review bot, while reviewing #242; the defect is outside that pull request.
Activity
tools, refset: the oracle harnesses share one input and output contra…
tools, refset: the oracle harnesses share one input and output contra…
tools, refset: the oracle harnesses share one input and output contra…
tools, refset: the oracle harnesses share one input and output contra…
tools, refset: the oracle harnesses share one input and output contra…
juliankang4 commentedon Oct 16, 2026
This is fixed on main by 7ed1967 ("refset: a nemotron id, completion count, or oracle numeric option that does not parse is refused").
tools/ref/hidden_ref.cppno longer usesatoifor these options:-c,-ub,-ngland-tgo throughparse_i32(lines 86 to 92 on main), and a value that does not parse makes it return 2 before any inference runs. So-c bad,-ngl badand-t badare refused instead of becoming 0 or the default. Closing.