fix(eform-cases): resolve case id from an input, not the router URL

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-element/case-edit-element.component.html

@@ -19,6 +19,7 @@ <h2 class="eform-section__title" *ngIf="showSectionTitle">{{ element.label }}</h
   <app-case-edit-switch
     (needUpdate)="emitNeedUpdate()"
     [dataItemList]="element.dataItemList"
+    [caseId]="caseId"
   ></app-case-edit-switch>
 
   <ng-container *ngIf="element.extraFieldsEnabled">
@@ -34,6 +35,7 @@ <h3 class="eform-field__label">{{ 'Extra picture' | translate }}</h3>
       <element-picture
         (pictureUpdated)="emitNeedUpdate()"
         [fieldValues]="element.extraPictures"
+        [caseId]="caseId"
       ></element-picture>
     </div>
 
@@ -44,7 +46,9 @@ <h3 class="eform-field__label">{{ 'Extra recording' | translate }}</h3>
 
   <ng-container *ngIf="element.elementList">
     <app-case-edit-element
+      (needUpdate)="emitNeedUpdate()"
       [element]="elem"
+      [caseId]="caseId"
       *ngFor="let elem of element.elementList"
     ></app-case-edit-element>
   </ng-container>

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-element/case-edit-element.component.ts

@@ -22,6 +22,13 @@ export class CaseEditElementComponent implements OnInit {
    * keeps the heading it has today.
    */
   @Input() showSectionTitle = true;
+  /**
+   * Id of the case being edited. Routed case pages may omit it — the picture
+   * element still falls back to the route params. Dialog hosts must supply it,
+   * because the ActivatedRoute they inject is the route the dialog was opened
+   * from and carries no case id at all.
+   */
+  @Input() caseId?: number;
   @Output() needUpdate: EventEmitter<void> = new EventEmitter<void>();
   requestModel: CaseEditRequest = new CaseEditRequest();
   requestModels: Array<CaseEditRequest> = [];

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-switch/case-edit-switch.component.html

@@ -18,7 +18,7 @@ <h3 class="eform-field__label" id="eformFieldLabel{{dataItem.id}}">{{dataItem.la
       </ng-container>
       <ng-container [ngSwitch]="dataItem.fieldType">
         <ng-container *ngSwitchCase="'Picture'">
-          <element-picture [fieldValues]="dataItem.fieldValues" [fieldId]="dataItem.id" (pictureUpdated)="emitNeedUpdate()"></element-picture>
+          <element-picture [fieldValues]="dataItem.fieldValues" [fieldId]="dataItem.id" [caseId]="caseId" (pictureUpdated)="emitNeedUpdate()"></element-picture>
         </ng-container>
         <ng-container *ngSwitchCase="'CheckBox'">
           <element-checkbox [fieldValue]="dataItem.fieldValues[0]"></element-checkbox>
@@ -59,7 +59,9 @@ <h3 class="eform-field__label" id="eformFieldLabel{{dataItem.id}}">{{dataItem.la
         <ng-container *ngSwitchCase="'FieldContainer'">
           <element-container
             [fieldValue]="dataItem.dataItemList"
-            [dataItemLabel]="dataItem.label">
+            [dataItemLabel]="dataItem.label"
+            [caseId]="caseId"
+            (needUpdate)="emitNeedUpdate()">
           </element-container>
         </ng-container>
         <ng-container *ngSwitchCase="'EntitySearch'">

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-switch/case-edit-switch.component.spec.ts

@@ -17,6 +17,7 @@ import {DataItemDto} from 'src/app/common/models';
 class StubPictureComponent {
   @Input() fieldValues: any;
   @Input() fieldId: any;
+  @Input() caseId: any;
 }
 
 function makeDataItem(overrides: Partial<DataItemDto> = {}): DataItemDto {

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-edit-switch/case-edit-switch.component.ts

@@ -8,6 +8,12 @@ import {DataItemDto} from 'src/app/common/models';
 })
 export class CaseEditSwitchComponent implements OnInit {
   @Input() dataItemList: Array<DataItemDto> = [];
+  /**
+   * Id of the case being edited, threaded down to the picture element. Optional
+   * — it is only needed where the ActivatedRoute cannot supply it, i.e. when
+   * the case editor is rendered inside a dialog rather than on a case route.
+   */
+  @Input() caseId?: number;
   @Output() needUpdate: EventEmitter<void> = new EventEmitter<void>();
 
   constructor() { }

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-container/element-container.component.html

@@ -5,6 +5,6 @@ <h6>{{dataItemLabel}}</h6>
     <mat-icon>{{isCollapsed ? 'chevron_right' : 'expand_more'}}</mat-icon>
   </mat-card-header>
   <mat-card-content class="section-collapse" [ngClass]="{'collapsed' : isCollapsed}">
-    <app-case-edit-switch [dataItemList]="dataItemList"></app-case-edit-switch>
+    <app-case-edit-switch [dataItemList]="dataItemList" [caseId]="caseId" (needUpdate)="emitNeedUpdate()"></app-case-edit-switch>
   </mat-card-content>
 </mat-card>

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-container/element-container.component.ts

@@ -1,4 +1,4 @@
-import { Component, Input} from '@angular/core';
+import { Component, EventEmitter, Input, Output} from '@angular/core';
 import { DataItemDto } from 'src/app/common/models';
 
 @Component({
@@ -12,13 +12,24 @@ export class ElementContainerComponent {
   dataItemList: Array<DataItemDto> = [];
   isCollapsed = true;
   @Input() dataItemLabel: string;
+  /**
+   * Id of the case being edited, threaded on down to the nested switch so a
+   * Picture field grouped inside this container still resolves a case id when
+   * the editor is rendered inside a dialog rather than on a case route.
+   */
+  @Input() caseId?: number;
   @Input()
   get fieldValue() {
     return this.dataItemList;
   }
   set fieldValue(val) {
     this.dataItemList = val;
   }
+  @Output() needUpdate: EventEmitter<void> = new EventEmitter<void>();
 
   constructor() {}
+
+  emitNeedUpdate() {
+    this.needUpdate.emit();
+  }
 }

eform-client/src/app/common/modules/eform-cases/components/case-edit/case-elements/element-picture/element-picture.component.ts

@@ -29,12 +29,20 @@ export class ElementPictureComponent implements OnChanges, OnDestroy {
 
   @Input() fieldValues: Array<FieldValueDto> = [];
   @Input() fieldId: number;
+  /**
+   * Case id supplied by the host component. It takes precedence over the route
+   * params below: inside a MatDialog the injected ActivatedRoute is the route
+   * the dialog was opened from, which carries neither ':id' nor ':sdkCaseId',
+   * so the fallback would resolve to NaN and the upload would fail with
+   * CaseNotFound. Routed case pages may keep omitting it.
+   */
+  @Input() caseId?: number;
   @Output() pictureUpdated: EventEmitter<void> = new EventEmitter<void>();
   buttonsLocked = false;
   geoObjects = [];
   images = [];
   galleryImages: GalleryItem[] = [];
-  caseId: number;
+  private routeCaseId: number;
 
   imageSub$: Subscription;
   rotateImageSub$: Subscription;
@@ -48,12 +56,14 @@ export class ElementPictureComponent implements OnChanges, OnDestroy {
   ngOnChanges(changes: SimpleChanges): void {
     if (changes && changes.fieldValues) {
       this.images = [];
-      this.activatedRouteSub$ = this.activateRoute.params.subscribe((params) => {
-        this.caseId = +params['id'];
-        if (isNaN(this.caseId)) {
-          this.caseId = +params['sdkCaseId'];
-        }
-      });
+      if (!this.hasCaseIdInput) {
+        this.activatedRouteSub$ = this.activateRoute.params.subscribe((params) => {
+          this.routeCaseId = +params['id'];
+          if (isNaN(this.routeCaseId)) {
+            this.routeCaseId = +params['sdkCaseId'];
+          }
+        });
+      }
       this.fieldValues.forEach(value => {
         if (value.uploadedDataObj) {
           this.geoObjects.push({
@@ -83,6 +93,21 @@ export class ElementPictureComponent implements OnChanges, OnDestroy {
     }
   }
 
+  /**
+   * True when the host explicitly bound a usable case id.
+   */
+  private get hasCaseIdInput(): boolean {
+    return Number.isFinite(this.caseId) && this.caseId > 0;
+  }
+
+  /**
+   * The bound input always wins; the route params are only a fallback for the
+   * routed case pages that do not pass the id down.
+   */
+  private get resolvedCaseId(): number {
+    return this.hasCaseIdInput ? this.caseId : this.routeCaseId;
+  }
+
   updateGallery() {
     this.galleryImages = [];
     this.images = this.images.sort((a, b) => a.fileName.localeCompare(b.fileName));
@@ -146,7 +171,7 @@ export class ElementPictureComponent implements OnChanges, OnDestroy {
   addPicture(newImage: File, modalId: string) {
     const fieldId = this.fieldId;
     this.addImageSub$ = this.imageService
-      .addNewImage(fieldId, this.caseId, newImage)
+      .addNewImage(fieldId, this.resolvedCaseId, newImage)
       .subscribe(data => {
         if (data && data.success) {
           this.dialog.getDialogById(modalId).close();