Network - 25480 - Bugfix - check appRoleAssignmentRequired before checking appRoleAssignedTo#1088
Closed
sandeepjha000 wants to merge 24 commits intodevfrom
Closed
Network - 25480 - Bugfix - check appRoleAssignmentRequired before checking appRoleAssignedTo#1088sandeepjha000 wants to merge 24 commits intodevfrom
sandeepjha000 wants to merge 24 commits intodevfrom
Conversation
Documented the provisioning process for Security Copilot Units (SCUs), including implementation effort, user impact, and configuration details.
Added information about Microsoft Entra ID RBAC for Security Copilot.
Added a new document detailing the management and monitoring of Security Compute Units (SCUs) for Microsoft Security Copilot, including implementation effort, user impact, and configuration guidance.
Document the management of plugins in Microsoft Security Copilot, including implementation effort and user impact.
Added documentation for the Threat Hunting Agent in Microsoft Defender, detailing implementation effort, user impact, overview, and configuration instructions.
Added documentation for the Defender Threat Intelligence Agent, detailing its implementation effort, user impact, and overview of its capabilities.
Document the use of Security Copilot for incident summaries and remediation.
Added documentation for analyzing potentially malicious files and scripts using Microsoft Security Copilot, including implementation effort, user impact, and overview of capabilities.
This document outlines the capabilities of Microsoft Security Copilot in providing AI-generated summaries of identities and devices, aiding security analysts in investigations and governance tasks.
Added documentation for Microsoft Defender Experts for XDR, detailing implementation effort, user impact, overview, configuration steps, and references.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Update SecOps pillar docs
peresys13
requested review from
Copilot
and removed request for
alexandair,
Copilot and
merill
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes assessment 25480 (Quick Access assignments) by adjusting how the Quick Access service principal is queried from Microsoft Graph and by incorporating appRoleAssignmentRequired into the pass/fail evaluation to avoid false negatives when assignments are implicitly “All Users”.
Changes:
- Reworks Graph collection into a two-step query (find SP → fetch details with
$expand=appRoleAssignedTo) to avoid silent empty expansions when combining$filter+$expand. - Updates evaluation logic to pass when
appRoleAssignmentRequiredisfalseeven ifappRoleAssignedTois empty. - Updates user-facing status/result messages for “not configured” and “unable to retrieve details” scenarios.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…rustassessment into bugfix/issue-973
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973