Skip to content

Fix C++20 build with howardhinnant_date=3.0.4 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naegelejd merged 1 commit into from
Mar 6, 2026
+4 −4
Merged

Fix C++20 build with howardhinnant_date=3.0.4 #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
- gxx_linux-64=15.1.0 # arch=x86_64
- gxx_linux-aarch64=15.1.0 # arch=aarch64
- hdf5=1.14.6
- howardhinnant_date=3.0.3
- howardhinnant_date=3.0.4
- ipykernel=6.30.1 # local
- just=1.43.0
- ninja=1.13.1
Expand Down
6 changes: 3 additions & 3 deletions tooling/internal/cpp/include/detail/ndjson/serializers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ struct adl_serializer<yardl::Date> {

static void from_json(ordered_json const& j, yardl::Date& value) {
std::stringstream ss{j.get<std::string>()};
ss >> date::parse("%F", value);
date::from_stream(ss, "%F", value);
if (ss.fail()) {
throw std::runtime_error("invalid date format");
}
Expand All @@ -145,7 +145,7 @@ struct adl_serializer<yardl::Time> {

static void from_json(ordered_json const& j, yardl::Time& value) {
std::stringstream ss{j.get<std::string>()};
ss >> date::parse("%T", value);
date::from_stream(ss, "%T", value);
if (ss.fail()) {
throw std::runtime_error("invalid time format");
}
Expand All @@ -160,7 +160,7 @@ struct adl_serializer<yardl::DateTime> {

static void from_json(ordered_json const& j, yardl::DateTime& value) {
std::stringstream ss{j.get<std::string>()};
ss >> date::parse("%FT%T", value);
date::from_stream(ss, "%FT%T", value);
if (ss.fail()) {
throw std::runtime_error("invalid datetime format");
}
Expand Down
Loading