Add adapted resource manifest for each module#284
Open
Gijsreyn wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces module-level *.dsc.manifests.json files with individual *.dsc.adaptedResource.json manifests so DSC versions before stable 3.3 can discover adapted PowerShell DSC resources.
Changes:
- Removed aggregate adapted-resource manifest files from each module.
- Added one adapted resource manifest per DSC resource.
- Preserved resource metadata, schema, capabilities, adapter, and module path information in the new per-resource files.
Reviewed changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resources/YarnDsc/YarnInstall.dsc.adaptedResource.json | Adds YarnInstall per-resource manifest. |
| resources/YarnDsc/yarndsc.dsc.manifests.json | Removes YarnDsc aggregate manifest. |
| resources/RustDsc/CargoToolInstall.dsc.adaptedResource.json | Adds CargoToolInstall per-resource manifest. |
| resources/RustDsc/rustdsc.dsc.manifests.json | Removes RustDsc aggregate manifest. |
| resources/PythonPip3Dsc/Pip3Package.dsc.adaptedResource.json | Adds Pip3Package per-resource manifest. |
| resources/PythonPip3Dsc/pythonpip3dsc.dsc.manifests.json | Removes PythonPip3Dsc aggregate manifest. |
| resources/NpmDsc/NpmInstall.dsc.adaptedResource.json | Adds NpmInstall per-resource manifest. |
| resources/NpmDsc/NpmPackage.dsc.adaptedResource.json | Adds NpmPackage per-resource manifest. |
| resources/NpmDsc/npmdsc.dsc.manifests.json | Removes NpmDsc aggregate manifest. |
| resources/Microsoft.WindowsSandbox.DSC/WindowsSandbox.dsc.adaptedResource.json | Adds WindowsSandbox per-resource manifest. |
| resources/Microsoft.WindowsSandbox.DSC/microsoftwindowssandboxdsc.dsc.manifests.json | Removes WindowsSandbox aggregate manifest. |
| resources/Microsoft.Windows.Settings/WindowsSettings.dsc.adaptedResource.json | Adds WindowsSettings per-resource manifest. |
| resources/Microsoft.Windows.Settings/microsoftwindowssettings.dsc.manifests.json | Removes WindowsSettings aggregate manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/Audio.dsc.adaptedResource.json | Adds Audio accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/EyeControl.dsc.adaptedResource.json | Adds EyeControl accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/FilterKeys.dsc.adaptedResource.json | Adds FilterKeys accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/Magnifier.dsc.adaptedResource.json | Adds Magnifier accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/MousePointer.dsc.adaptedResource.json | Adds MousePointer accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/StickyKeys.dsc.adaptedResource.json | Adds StickyKeys accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/Text.dsc.adaptedResource.json | Adds Text accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/TextCursor.dsc.adaptedResource.json | Adds TextCursor accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/ToggleKeys.dsc.adaptedResource.json | Adds ToggleKeys accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/VisualEffect.dsc.adaptedResource.json | Adds VisualEffect accessibility manifest. |
| resources/Microsoft.Windows.Setting.Accessibility/microsoftwindowssettingaccessibility.dsc.manifests.json | Removes accessibility aggregate manifest. |
| resources/Microsoft.Windows.Developer/AdvancedNetworkSharingSetting.dsc.adaptedResource.json | Adds AdvancedNetworkSharingSetting manifest. |
| resources/Microsoft.Windows.Developer/DeveloperMode.dsc.adaptedResource.json | Adds DeveloperMode manifest. |
| resources/Microsoft.Windows.Developer/EnableDarkMode.dsc.adaptedResource.json | Adds EnableDarkMode manifest. |
| resources/Microsoft.Windows.Developer/EnableLongPathSupport.dsc.adaptedResource.json | Adds EnableLongPathSupport manifest. |
| resources/Microsoft.Windows.Developer/EnableRemoteDesktop.dsc.adaptedResource.json | Adds EnableRemoteDesktop manifest. |
| resources/Microsoft.Windows.Developer/FirewallRule.dsc.adaptedResource.json | Adds FirewallRule manifest. |
| resources/Microsoft.Windows.Developer/NetConnectionProfile.dsc.adaptedResource.json | Adds NetConnectionProfile manifest. |
| resources/Microsoft.Windows.Developer/OsVersion.dsc.adaptedResource.json | Adds OsVersion manifest. |
| resources/Microsoft.Windows.Developer/PowerPlanSetting.dsc.adaptedResource.json | Adds PowerPlanSetting manifest. |
| resources/Microsoft.Windows.Developer/ShowSecondsInClock.dsc.adaptedResource.json | Adds ShowSecondsInClock manifest. |
| resources/Microsoft.Windows.Developer/Taskbar.dsc.adaptedResource.json | Adds Taskbar manifest. |
| resources/Microsoft.Windows.Developer/UserAccessControl.dsc.adaptedResource.json | Adds UserAccessControl manifest. |
| resources/Microsoft.Windows.Developer/WindowsCapability.dsc.adaptedResource.json | Adds WindowsCapability manifest. |
| resources/Microsoft.Windows.Developer/WindowsExplorer.dsc.adaptedResource.json | Adds WindowsExplorer manifest. |
| resources/Microsoft.Windows.Developer/microsoftwindowsdeveloper.dsc.manifests.json | Removes developer aggregate manifest. |
| resources/Microsoft.VSCode.Dsc/VSCodeExtension.dsc.adaptedResource.json | Adds VSCodeExtension manifest. |
| resources/Microsoft.VSCode.Dsc/microsoftvscodedsc.dsc.manifests.json | Removes VSCode aggregate manifest. |
| resources/Microsoft.DotNet.Dsc/DotNetToolPackage.dsc.adaptedResource.json | Adds DotNetToolPackage manifest. |
| resources/Microsoft.DotNet.Dsc/microsoftdotnetdsc.dsc.manifests.json | Removes DotNet aggregate manifest. |
| resources/GitDsc/GitClone.dsc.adaptedResource.json | Adds GitClone manifest. |
| resources/GitDsc/GitConfigUserEmail.dsc.adaptedResource.json | Adds GitConfigUserEmail manifest. |
| resources/GitDsc/GitConfigUserName.dsc.adaptedResource.json | Adds GitConfigUserName manifest. |
| resources/GitDsc/GitRemote.dsc.adaptedResource.json | Adds GitRemote manifest. |
| resources/GitDsc/gitdsc.dsc.manifests.json | Removes GitDsc aggregate manifest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,54 @@ | |||
| { | |||
| "$schema": "https://aka.ms/dsc/schemas/v3/bundled/adaptedresource/manifest.json", | |||
| "type": "GitDsc/GitClone", | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This pull request reverts #262 as
*.dsc.manifests.jsondiscovery is only available in 3.3.0-preview.* release. Thus, it adds individual*.dsc.adaptedResource.jsonfor each resource. In the future, when there's a stable release of DSC 3.3.0, it can be reverted back to using*.dsc.manifests.jsonNote
The module used isn't shipped to the PowerShell gallery, but can be found at: https://github.com/dsccommunity/DscResource.Authoring
🔗 References
Fix #272.
🔍 Validation
$env:PSModulePathThe resource(s) should be listed with the
requireAdapterset.✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow