sessions: Show close actions in side-by-side headers - #339175
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoOct 1, 2026
Merged
Sandeep Somavarapu (sandy081) merged 2 commits into
Sandeep Somavarapu (sandy081) merged 2 commits into
Conversation
Expose the existing close commands beside the overflow menu for multi-session and split-chat layouts, while preserving the compact close glyph on tabs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
October 1, 2026 20:44
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
October 1, 2026 20:46
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new icon-only close actions need descriptive accessible labels distinguishing sessions from chat groups.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds contextual close buttons to side-by-side session and chat-group headers.
Changes:
- Adds scoped context state to distinguish session and chat-group toolbars.
- Contributes regular-glyph close actions to header toolbars.
- Extends tests for visibility, targeting, and icon selection.
| File | Description |
|---|---|
src/vs/sessions/common/contextkeys.ts |
Defines session-toolbar context state. |
src/vs/sessions/browser/parts/sessionHeader.ts |
Marks session-level toolbars. |
src/vs/sessions/browser/parts/chatGroupView.ts |
Scopes toolbar state per chat group. |
src/vs/sessions/contrib/sessions/browser/sessionsActions.ts |
Adds visible header close actions. |
src/vs/sessions/test/browser/chatGroupsView.test.ts |
Tests toolbar context behavior. |
src/vs/sessions/contrib/sessions/test/browser/sessionsActions.test.ts |
Tests action placement and icons. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (6)
|
| Before | After |
|---|---|
 |
 |
sessions/grid/sessionsGrid/NestedSplits/Light
| Before | After |
|---|---|
 |
 |
sessions/grid/sessionsGrid/Maximized/Light
| Before | After |
|---|---|
 |
 |
sessions/grid/sessionsGrid/MultipleChats/Light
| Before | After |
|---|---|
 |
 |
sessions/accountMenu/WeeklyLimitOnly/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
| Before | After |
|---|---|
 |
 |
3 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Give icon-only close actions surface-specific accessible names and make menu tests deterministic across Browser and Electron-Unit runners. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
approved these changes
Oct 1, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/bug-fix-general-issue-19f614e7
branch
October 1, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a visible close action beside the overflow menu when sessions or chats are opened side by side.
Validation:
npm run compile— passednpm run hygiene— passednpm run typecheck-client— passednpm run transpile-client— passed