Skip to content

Remove customization count badge from Agents window - #339171

Merged
Hawk Ticehurst (hawkticehurst) merged 1 commit into
mainfrom
agents/remove-customization-count-badge
Oct 1, 2026
Merged

Hawk Ticehurst (hawkticehurst) merged 1 commit into
mainfrom
agents/remove-customization-count-badge

Conversation

@hawkticehurst

@hawkticehurst Hawk Ticehurst (hawkticehurst) commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

This pull request removes the visible total-count badge from the Customizations navigation row in the Agents window, as requested. Key changes include:

  • Badge Removal: The visual badge has been removed from sessionsList.ts, while the count remains in the accessibility label.
  • CSS Update: Obsolete badge styling has been removed from sessionsList.css.
  • Testing: Updated unit tests and visual fixture descriptions to reflect the changes.
  • Validation: All tests passed successfully, ensuring no unintended side effects.

The migration warning indicator remains unchanged, preserving the overall functionality of the Agents window.

Image

Copilot AI balanced review requested due to automatic review settings October 1, 2026 20:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused implementation and tests consistently remove only the visual badge while preserving accessibility and migration behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Removes the visible Customizations count badge while retaining the count in its accessibility label and preserving the migration warning.

Changes:

  • Removes badge rendering, styling, and dependencies.
  • Updates unit and visual fixture expectations.
  • Keeps accessible count announcements intact.
File Description
sessionsList.ts Removes the visible count badge implementation.
sessionsList.css Removes obsolete badge styling.
sessionsList.test.ts Verifies badge absence and retained accessibility label.
sessionsList.fixture.ts Updates visual descriptions.
sessionsListFixtureUtils.ts Clarifies the count’s accessibility-only purpose.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 4fbe620f Current: bb07bcf9

Changed (5)

sessions/sessionsList/SessionsList_CustomizationsNavigationTreatment/Light
Before After
before after
sessions/sessionsList/SessionsList_CustomizationsMigrationsAvailable/Light
Before After
before after
sessions/accountMenu/WeeklyAndFiveHourLimits/Light
Before After
before after
sessions/accountMenu/WeeklyLimitOnly/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
Before After
before after

@hawkticehurst
Hawk Ticehurst (hawkticehurst) merged commit 990fb53 into main Oct 1, 2026
36 checks passed
@hawkticehurst
Hawk Ticehurst (hawkticehurst) deleted the agents/remove-customization-count-badge branch October 1, 2026 20:56
@vs-code-engineering vs-code-engineering Bot added this to the 1.141.0 milestone Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants