Update MCP modal icon placement and styling - #339170
Merged
Hawk Ticehurst (hawkticehurst) merged 2 commits intoOct 1, 2026
Merged
Conversation
Render compatibility severity icons inline at compact size and match their message colors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Hawk Ticehurst (hawkticehurst)
October 1, 2026 20:13
View session
Hawk Ticehurst (hawkticehurst)
enabled auto-merge (squash)
October 1, 2026 20:14
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The 12px icons use full-size glyphs, and the placement test does not assert that the icon is first.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Repositions MCP compatibility icons beside their messages to keep row actions aligned.
Changes:
- Moves compatibility icons from actions into status messages.
- Applies compact sizing, inherited colors, and decorative ARIA treatment.
- Updates unit tests and visual fixtures.
| File | Description |
|---|---|
mcpListWidget.ts |
Moves icons into compatibility messages. |
aiCustomizationManagement.css |
Styles inline compatibility icons. |
mcpListWidget.test.ts |
Updates compatibility-icon tests. |
aiCustomizationManagementEditor.fixture.ts |
Updates visual fixture states and descriptions. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersAllStates/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
roblourens
approved these changes
Oct 1, 2026
Hawk Ticehurst (hawkticehurst)
deleted the
agents/mcp-modal-icon-placement-update
branch
October 1, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338493
This pull request implements changes to the MCP customization modal by repositioning the warning and error icons. The icons are now displayed at the beginning of their respective messages, improving visual alignment and clarity.
Changes made:
mcpListWidget.ts.aiCustomizationManagement.css, ensuring they match the text size.aria-hiddento maintain accessibility.mcpListWidget.test.tsto reflect these changes.This update enhances the user experience by providing a more cohesive visual representation of the status messages.
Screenshot