chat: Use AgentFinder saved feed for featured customizations - #339166
Draft
Paul (pwang347) wants to merge 4 commits into
Draft
Paul (pwang347) wants to merge 4 commits into
Paul (pwang347) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Screenshot evidence from the
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Enterprise authentication tokens must be prevented from reaching the fixed public AgentFinder endpoint.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds product-configured AgentFinder featured feeds to the AI Customizations Discover page.
Changes:
- Fetches authenticated, ordered saved-resource feeds.
- Integrates featured results while preserving regular browse results and fallback behavior.
- Adds transport, UI, fixture, and documentation coverage.
| File | Description |
|---|---|
src/vs/base/common/product.ts |
Adds the featured-feed product configuration. |
src/vs/platform/agentFinder/common/agentFinderRestProvider.ts |
Fetches and validates saved feeds. |
src/vs/platform/agentFinder/test/common/agentFinderRestProvider.test.ts |
Tests feed parsing and authentication failures. |
src/vs/platform/customizationMarketplace/common/customizationMarketplaceService.ts |
Defines the featured collection API. |
src/vs/sessions/AI_CUSTOMIZATIONS.md |
Documents featured-feed behavior. |
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationDiscoveryPage.ts |
Renders and caches featured results. |
src/vs/workbench/contrib/chat/browser/aiCustomization/customizationMarketplaceWorkbenchService.ts |
Composes authentication and feed transport. |
src/vs/workbench/contrib/chat/test/browser/aiCustomization/aiCustomizationDiscoveryPage.test.ts |
Tests ordering and failure behavior. |
src/vs/workbench/contrib/chat/test/browser/aiCustomization/customizationMarketplaceWorkbenchService.test.ts |
Tests authenticated composition. |
src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts |
Adds featured-feed visual coverage. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+180
to
+189
| const account = this.defaultAccountService.currentDefaultAccount ?? await raceCancellationError(this.defaultAccountService.getDefaultAccount(), token); | ||
| if (!account) { | ||
| throw new Error(localize('customizationMarketplace.agentFinderSignInRequired', "Sign in to view featured customizations.")); | ||
| } | ||
| const sessions = await raceCancellationError(this.authenticationService.getSessions(account.authenticationProvider.id, [], { silent: true }, true), token); | ||
| const currentAccount = this.defaultAccountService.currentDefaultAccount; | ||
| if (!currentAccount || currentAccount.authenticationProvider.id !== account.authenticationProvider.id || | ||
| currentAccount.sessionId !== account.sessionId || currentAccount.accountName !== account.accountName) { | ||
| throw new CancellationError(); | ||
| } |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
sessions/accountMenu/WeeklyLimitOnly/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverInfiniteScroll/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
| Before | After |
|---|---|
 |
 |
Added (1)
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverFeaturedFeed/Light
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentFinderFeaturedFeedIdBackend contract: Saved Resource Feed API
Related to github/copilot-ecosystem#1498.
Testing
./scripts/test.sh --run src/vs/platform/agentFinder/test/common/agentFinderRestProvider.test.ts --run src/vs/workbench/contrib/chat/test/browser/aiCustomization/customizationMarketplaceWorkbenchService.test.ts --run src/vs/workbench/contrib/chat/test/browser/aiCustomization/aiCustomizationDiscoveryPage.test.ts(153 passing)npm run eslint -- src/vs/base/common/product.ts src/vs/platform/customizationMarketplace/common/customizationMarketplaceService.ts src/vs/platform/agentFinder/common/agentFinderRestProvider.ts src/vs/platform/agentFinder/test/common/agentFinderRestProvider.test.ts src/vs/workbench/contrib/chat/browser/aiCustomization/customizationMarketplaceWorkbenchService.ts src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationDiscoveryPage.ts src/vs/workbench/contrib/chat/test/browser/aiCustomization/customizationMarketplaceWorkbenchService.test.ts src/vs/workbench/contrib/chat/test/browser/aiCustomization/aiCustomizationDiscoveryPage.test.ts src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.tsnpm run transpile-clientgit diff --checkchat/aiCustomizations/aiCustomizationManagementEditor/DiscoverFeaturedFeed/Darkmain:npm run typecheck-clientandnpm run valid-layers-check(src/vs/platform/localTranscription/node/localTranscriptionService.ts:548,557)npm run hygiene(package.jsondeclares Copilot runtime1.0.90, while@github/copilot-sdkbundles1.0.89-7)Screenshot