Skip to content

ci: run ESLint after parallel compile checks - #339153

Open
Bryan Chen (bryanchen-d) with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-github-actions-job-again
Open

Bryan Chen (bryanchen-d) with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-github-actions-job-again

Conversation

Copilot AI commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Run the full ESLint check immediately after the parallel compile/hygiene checks, rather than concurrently with them. Keep all existing checks and failure gates.

This is a standalone infrastructure change, separated from the accessibility fix in #339121. That PR's diff is back to the audio-error fix only.

Evidence

The original PR failed twice with [eslint] Killed and ERROR: "eslint" exited with 137, while core-ci was bundling:

A bounded survey of 200 recent Code OSS runs on October 1 found the same signature on three other PRs:

These are SIGKILL/exit-137 observations, consistent with runner memory pressure. Kernel OOM diagnostics were not available, so this does not claim a proven kernel OOM cause or attribute unrelated CI failures to it.

Impact

  • No compiler settings, lint rules, target files, or validation gates change.
  • ESLint remains mandatory and still checks the full repository.
  • Lower overlapping resource demand, at the cost of losing lint/compile overlap.
  • Applies to Code OSS pull-request builds; Azure Pipelines is unchanged.
  • An equivalent scheduling canary passed Compile & Hygiene: 4m41s for parallel checks, then 2m09s for ESLint. These are observed step durations, not a measured before/after latency delta.

Validation

  • YAML assertions verify all seven other checks remain in the parallel group and full ESLint runs immediately afterward without conditional skipping or continue-on-error.
  • All three existing ESLint-driver tests pass.
  • git diff --check passes.
  • Precommit hygiene completes; it selects no files for this YAML-only change.
  • Exact-head Code OSS CI passes on bbe8269a1597633841e0cf6e0755ef14d5176977, including all platform jobs. The Compile & Hygiene job ran parallel checks in 4m21s, then ESLint in 1m58s.
  • All 34 completed PR checks pass; the separate VS Code PR Check approval gate is still pending.

Authored with Copilot

Copilot AI balanced review requested due to automatic review settings October 1, 2026 18:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: bryanchen-d <41454397+bryanchen-d@users.noreply.github.com>
Bryan Chen (bryanchen-d) added a commit to vscodebot-pr/vscode that referenced this pull request Oct 1, 2026
Restore the original Code OSS workflow in this PR. Track the shared ESLint resource-contention fix independently in microsoft#339153.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the resource-contention mitigation in this standalone CI PR, separate from the accessibility fix in #339121.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bryanchen-d Bryan Chen (bryanchen-d) changed the title [WIP] Fix failing GitHub Actions job for compile and hygiene ci: run ESLint after parallel compile checks Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: d6c9edb7 Current: 9266fc62

Changed (1)

chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
Before After
before after

2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants