Skip to content

fix: reject with proper Error on audio error event (fixes #339115) #339121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VS Code PR Bot (vscodebot-pr) wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix: reject with proper Error on audio error event (fixes #339115) #339121

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a556566
fix: reject with proper Error on audio error event (fixes #339115)
github-actions[bot] Oct 1, 2026
7d73618
ci: run ESLint after parallel compile checks
bryanchen-d Oct 1, 2026
60d04a7
ci: separate workflow scheduling fix from accessibility change
bryanchen-d Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/vs/platform/accessibilitySignal/browser/accessibilitySignalService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,12 @@ function doPlayAudio(url: string, volume: number, disposables: DisposableStore):
disposables.add(addDisposableListener(audio, 'ended', () => {
resolve(audio);
}));
disposables.add(addDisposableListener(audio, 'error', (e) => {
// When the error event fires, ended might not be called
reject(e.error);
disposables.add(addDisposableListener(audio, 'error', () => {
// When the error event fires, ended might not be called.
// The media `error` event is a plain Event without an `error`
// property; the actual failure is described by `audio.error`.
const mediaError = audio.error;
reject(new Error(mediaError ? `Failed to play audio (code ${mediaError.code}): ${mediaError.message}` : 'Failed to play audio'));
}));
audio.play().catch(e => {
// When play fails, the error event is not fired.
Expand Down
Loading