Skip to content

chat: Focus installed customizations from Discover - #339116

Merged
Jessie Houghton (houghj16) merged 3 commits into
mainfrom
agents/customize-item-click-behavior
Oct 1, 2026
Merged

Jessie Houghton (houghj16) merged 3 commits into
mainfrom
agents/customize-item-click-behavior

Conversation

@houghj16

@houghj16 Jessie Houghton (houghj16) commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #338768
image
image

What changed

  • Keep detail-page navigation for uninstalled Discover items.
  • Route installed Discover items to their management list and reveal, select, and focus the matching row.
  • Wait for asynchronous prompt and plugin list loading before applying the redirected selection.
  • Show Discover as the selected sidebar tab with the same theme colors and accessibility state as the other tabs.

Why

Installed customizations are easier to find and manage from their list context, while available marketplace items still need their detail page. The Discover navigation state now also clearly reflects the active page. Fixes #338768.

Validation

  • npm run compile — passed
  • npm run typecheck-client — passed
  • npm run stylelint -- src\vs\workbench\contrib\chat\browser\aiCustomization\media\aiCustomizationManagement.css — passed
  • npm run transpile-client — passed
  • scripts\test.bat for the four focused AI customization suites — 256 passing
  • git diff --check — passed

Copilot AI balanced review requested due to automatic review settings October 1, 2026 15:26
@houghj16
Jessie Houghton (houghj16) force-pushed the agents/customize-item-click-behavior branch from d822f15 to 578fee3 Compare October 1, 2026 15:36
roblourens
roblourens previously approved these changes Oct 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Recorded non-installed states are misrouted, high-contrast selection is invisible, and MCP targeting can select the wrong row.

Review effort: Balanced
Findings: 4 Medium severity

Open (4)
What changed in this PR

Routes installed Discover items to their management rows while preserving details for available items and highlighting Discover navigation.

Changes:

  • Adds reveal/select/focus APIs for prompt, plugin, and MCP lists.
  • Redirects installed catalog items to management sections.
  • Adds selected and accessibility state for Discover.
File Description
aiCustomizationDiscoveryPage.ts Routes installed items to management lists.
aiCustomizationManagementEditor.ts Coordinates section loading and row focus.
aiCustomizationWelcomePage.ts Defines installed navigation targets.
pluginListWidget.ts Reveals plugins by URI.
mcpListWidget.ts Reveals MCP servers by identity.
aiCustomizationManagement.css Styles selected Discover navigation.
aiCustomizationDiscoveryPage.test.ts Tests installed-item routing.
aiCustomizationManagementEditor.test.ts Tests loading, focus, and selected state.
pluginListWidget.test.ts Tests plugin row focus.
mcpListWidget.test.ts Tests MCP row focus.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts Outdated
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 4fbe620f Current: 5724cb3e

Changed (25)

sessions/accountMenu/WeeklyAndFiveHourLimits/Light
Before After
before after
sessions/accountMenu/WeeklyLimitOnly/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePageNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverWithMcpGalleryOnly/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/OverviewWithConnectorsEnabled/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/OverviewWithMarketplaceDisabled/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverWithPluginSourceOnly/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/EnableDiscoverFromOverview/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DisableDiscoverToOverview/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsDiscover/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverSearchResults/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverSearchResultsNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverClearedSearch/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverCopilotConnector/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverInfiniteScroll/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverInstalledFilter/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverError/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverLoading/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverSearchLoading/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverInstallStates/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverMissingInstallation/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverInstallError/Light
Before After
before after

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Route installed Discover items to their management lists, wait for asynchronous list loading, and reveal the matching focused row. Also keep the Discover navigation state aligned with the other sidebar tabs.\n\nFixes #338768\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Only redirect fully installed marketplace entries to management lists, and preserve stable MCP and Connector identities when revealing their rows. Keep the Discover selection visible in high-contrast themes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain the upstream installed-item detail payloads while carrying the stable identities used to reveal management-list rows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
Jessie Houghton (houghj16) force-pushed the agents/customize-item-click-behavior branch from dcb0f57 to 44ae335 Compare October 1, 2026 20:11
@houghj16
Jessie Houghton (houghj16) merged commit 6b649b3 into main Oct 1, 2026
35 checks passed
@houghj16
Jessie Houghton (houghj16) deleted the agents/customize-item-click-behavior branch October 1, 2026 20:33
@vs-code-engineering vs-code-engineering Bot added this to the 1.141.0 milestone Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on the "Discover" tab doesn't highlight the tab

5 participants