Modern UI: Prevent vertical scrolling when dragging connected tabs (revised) - #338180
Open
na2co3 (na2co3-ftw) wants to merge 8 commits into
Open
na2co3 (na2co3-ftw) wants to merge 8 commits into
na2co3 (na2co3-ftw) wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The tests do not directly verify that dragging cannot create a vertical scroll range.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns connected-tab decorations with the tab container to prevent vertical scrolling during drag operations.
Changes:
- Corrects fill, edge, and overflow geometry.
- Preserves upper-row background clipping.
- Updates geometry-focused tests.
| File | Description |
|---|---|
multiEditorTabsControl.test.ts |
Updates tab geometry expectations. |
modernUI.contribution.test.ts |
Updates clipping and inset expectations. |
connectedEditorTabs.css |
Aligns connected-tab decorations with their container. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
In this change, the |
Contributor
Author
|
Fixed a failing test. |
The floating-panels class enables the bottom offsets and transforms that define connected tab geometry.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revised from #336879
Problem
In Modern UI with connected tabs, dragging a tab can cause the tab strip to scroll vertically.
2026-09-19.13-15-17.mp4
Cause
The active tab's
tab-fillandtab-connected-edgeelements extend below thetabs-container.The
tabs-containerreserves 1px of bottom padding for the bottom border, but these elements extend 2px below the content area.When(fixed in #339028)workbench.editor.wrapTabsis enabled, the fills and connected edges in the last row extend by an additional 1px because the tabs container has no bottom padding for equal row sizing.Fix
tab-fillandtab-connected-edgewith the bottom of thetabs-container.tab-connected-overflow-edgechildren for the new height.background-clipfor active fills in the last row so that they continue to cover the bottom border correctly.