-
Notifications
You must be signed in to change notification settings - Fork 43k
Editor: Refine connected tabs UI #337126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Cherry Wang (chryw)
merged 30 commits into
main
from
dev/cherwan/agents/connected-tabs-ui-refinement
Sep 23, 2026
Merged
Editor: Refine connected tabs UI #337126
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
77265b8
Editor: stabilize connected tabs across zoom levels
chryw e01ff4f
test: update connected tab strip geometry
chryw 6f8f682
Editor: align connected tab actions to the top edge
chryw 88c7618
test: update component screenshot baseline
chryw ca041dc
Editor: share modern tab row geometry
chryw dcb5e3d
test: restore stable component screenshot baseline
chryw 3495d12
Editor: isolate connected tab colors and borders
chryw 0e81bc0
Editor: share connected tab left border
chryw 2029405
Editor: simplify connected tab color ownership
chryw e8263bf
Editor: describe connected tab color as reusable
chryw 9ad5434
Editor: centralize connected tab ownership
chryw 463cc85
docs: define connected tab ownership
chryw 9de120c
Editor: derive connected action height from the row
chryw 9e66d76
Editor: isolate all connected tab palettes
chryw b519284
Editor: balance connected tab close spacing
chryw 95fbe92
Editor: complete connected tab spacing
chryw bc06ad0
Editor: balance terminal tab actions
chryw 3a00dd0
Editor: share connected tab frame borders
chryw fbbeef5
Editor: give frame sole border ownership
chryw b14fea7
Editor: center connected tab actions
chryw d31aa2e
Editor: repair connected tab outline regressions
chryw 1a0bdf6
Editor: derive close clearance from the tab surface
chryw a422e88
Editor: keep compact tab outlines visible under actions
chryw f502a1c
Editor: keep wrapped tab reservation width invariant
chryw 319b4c0
Editor: explicitly retain high contrast close indicators
chryw c98b9de
Editor: stabilize connected tab surfaces and close targets
chryw bc93078
Merge main to incorporate upstream CI fixes
chryw 08e1341
Editor: respect disabled connected tab action hover state
chryw 8e6b60d
Editor: consolidate connected tab high-contrast frames
chryw 55a54e6
Editor: ignore unrendered frame color in connected tab tests
chryw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Review: Nit: With
workbench.editor.pinnedTabsOnSeparateRowenabled and no sticky editors,MultiRowEditorControlretains a hidden sticky control asfirstElementChild. The visible row therefore never getsconnected-tab-top-row, including after unpinning the final sticky editor. In Dark/Light 2026 this paints an extra active-cap top stroke instead of sharing the editor frame. Could this identify the first visible/nonempty tab bar, with coverage for an empty pinned row and the final unpin transition?