sessions: show F2 for chat rename actions - #336931
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoSep 20, 2026
Merged
Sandeep Somavarapu (sandy081) merged 2 commits into
Sandeep Somavarapu (sandy081) merged 2 commits into
Conversation
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 20, 2026 17:11
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 20, 2026 17:12
View session
Route header and nested-chat rename menus through their F2-bound actions while preserving inline rename behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
force-pushed
the
sandy081/agents/inline-session-rename-followup
branch
from
September 20, 2026 17:18
ff7dd96 to
a80c38a
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The chat-tab rename surface remains unchanged, and accessibility help resolves the wrong command’s shortcut for header rename.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds F2-driven rename behavior across Agents Window session and nested-chat surfaces.
Changes:
- Adds header and nested-chat rename keybindings/routing.
- Preserves focus and supports offscreen inline rename targets.
- Updates accessibility help, validation behavior, and regression tests.
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/test/browser/sessionsSessionManagementActions.test.ts | Tests rename keybinding scopes. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsRename.test.ts | Expands inline rename and focus tests. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsListContextMenu.test.ts | Tests shared chat rename menu registration. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts | Updates callback style. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts | Returns asynchronous open operations. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts | Coordinates opening, focus, validation, and offscreen rename. |
| src/vs/sessions/contrib/sessions/browser/sessionsActions.ts | Registers F2 and shared rename actions. |
| src/vs/sessions/contrib/sessions/browser/media/sessionsList.css | Hides hover details during rename. |
| src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts | Documents header rename behavior. |
| src/vs/base/browser/ui/inputbox/inputBox.ts | Disposes validation resize observation correctly. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 task
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
5 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Use the shared chat rename command from tab menus and let focused-tab F2 preserve inline editing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 20, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/inline-session-rename-followup
branch
September 20, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333671
Adds the F2 keybinding to the active session header rename action and uses the existing F2-bound chat rename command for nested-chat context menus. Keyboard invocation resolves the active session while preserving inline rename behavior and chat-specific routing.
Also updates the Agents Window accessibility help and adds regression coverage for keybinding scope, command routing, and context-menu registration.
Validation:
npm run compilenpm run hygiene