Include problem count badge in high contrast pane header outline - #336913
Open
Mayank Kamra (mkamra2000) wants to merge 2 commits into
Open
Mayank Kamra (mkamra2000) wants to merge 2 commits into
Mayank Kamra (mkamra2000) wants to merge 2 commits into
Conversation
In Dark and Light High Contrast themes, the focus/contrast outline on panel section headers only enclosed the title label, excluding the adjacent problem/item count badge. Adjust the outline target and layout container so the focus boundary wraps both the section label and its counter badge consistently. Fixes microsoft#172569
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Copilot started reviewing on behalf of
Mayank Kamra (mkamra2000)
September 20, 2026 12:03
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Incomplete selector migration causes nested outlines and still excludes badges in some layouts.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Expands high-contrast pane header outlines to include count badges.
Changes:
- Moves title outlines from labels to complete action items.
| File | Description |
|---|---|
src/vs/workbench/browser/parts/media/paneCompositePart.css |
Updates pane header outline selectors. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172569
Summary of Changes
In Dark High Contrast and Light High Contrast themes, the pane section header focus/contrast outline only wrapped the text label, excluding the adjacent problem/item counter badge.
This change adjusts the header outline boundary so that both the title label and its associated count badge are enclosed inside the contrast outline together.
Verification Steps
Preferences: Color Theme).Screenshots