Modern UI: Fix background glitch at connected tab overflow edge - #336873
Open
na2co3 (na2co3-ftw) wants to merge 1 commit into
Open
na2co3 (na2co3-ftw) wants to merge 1 commit into
na2co3 (na2co3-ftw) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CSS fix is consistent with the intended geometry and has targeted regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes a background leak at the right overflow edge of connected editor tabs.
Changes:
- Extends the overflow cap behind the shoulder.
- Updates regression assertions for the new geometry.
| File | Description |
|---|---|
connectedEditorTabs.css |
Extends the overflow cap to the bottom edge. |
multiEditorTabsControl.test.ts |
Verifies the cap reaches the bottom across HC themes and widths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a background glitch at the right overflow edge of connected editor tabs in Modern UI.
The overflow cap now extends behind the shoulder instead of stopping at the shoulder radius. This prevents the tab strip background from showing through at the bottom edge.
Screenshots
Before:
After:
For visibility,
editorGroupHeader.tabsBackgroundwas set to red.