Fix migration activity persistence after reverting a customization - #336828
Open
Hawk Ticehurst (hawkticehurst) wants to merge 2 commits into
Open
Hawk Ticehurst (hawkticehurst) wants to merge 2 commits into
Hawk Ticehurst (hawkticehurst) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Hawk Ticehurst (hawkticehurst)
September 18, 2026 20:07
View session
Hawk Ticehurst (hawkticehurst)
marked this pull request as ready for review
September 18, 2026 20:08
Hawk Ticehurst (hawkticehurst)
enabled auto-merge (squash)
September 18, 2026 20:09
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The copied-file preservation branch needs regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Reconciles persisted customization migration activity after reverted migrations.
Changes:
- Adds stable migration keys for files and MCP servers.
- Removes stale current and legacy activity while preserving copied-file records.
- Adds regression coverage for activity reconciliation.
| File | Description |
|---|---|
aiCustomizationManagementEditor.ts |
Reconciles and keys migration activity. |
customizationMigrationDashboard.ts |
Adds optional migration keys. |
aiCustomizationManagementEditor.test.ts |
Tests current and legacy activity removal. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
previously approved these changes
Sep 18, 2026
Cover the reconciliation exception that keeps copy migration activity when its source remains a migration candidate.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Base:
|
Henning Dieterichs (hediet)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336731
This pull request addresses the issue where customization migration activity remains after a migration is reverted, as outlined in issue #336731. The changes ensure that stale migration activity is properly reconciled when migration candidates are refreshed.
Changes
Validation
git diff --checkpass without issues.