Stop polling unchanged thinking content in chat - #336101
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 4 commits into
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 4 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 4 commits into
Conversation
Stop the progressive render loop when the accepted thinking part has unchanged text and duration. Continue accepting replacement model objects so generated titles are persisted to the current part, and preserve grouped-section identity. Add regression coverage for model mutations, generated titles, and render-loop pause/resume. Refs #275176. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 14, 2026 03:41
View session
Dmitriy Vasyura (dmitrivMS)
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Array-valued thinking parts still poll indefinitely because renderer splitting prevents the new identity check from succeeding.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open findings (1)
What changed in this PR
Stops unnecessary polling when rendered thinking content is unchanged.
Changes:
- Compares normalized thinking text, duration, and model identity.
- Adds regression coverage for updates, replacements, grouping, and timer behavior.
| File | Description |
|---|---|
chatThinkingContentPart.ts |
Detects unchanged thinking content. |
chatThinkingContentPart.test.ts |
Tests content comparison and title persistence. |
chatListRenderer.test.ts |
Tests progressive-render polling pause/resume. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Track the original source of array-valued thinking and compare its active section snapshot, preserving replacement objects, lazy section ordering, and generated-title write-back. Treat trailing response removals as changes in both rendering paths and truncate disposed entries so cleared content cannot survive the no-change fast path. Add renderer regressions for both review findings. Refs #275176. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve upstream thinking-group rebuilding and expansion behavior while retaining the no-op polling, array-source, and trailing-removal fixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bring in upstream rendering and remount changes while retaining the verified thinking polling, array-source, and trailing-removal fixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### baseUI/KeyboardFocusedToggle/Dark
#### baseUI/KeyboardFocusedToggle/DarkHighContrast
#### baseUI/KeyboardFocusedToggle/Light
#### baseUI/KeyboardFocusedToggle/LightHighContrast
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/CodexSkillMissingDescriptionHover/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/CodexSkillMissingDescriptionHover/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/MigrationDashboard/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/MigrationDashboard/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/SessionsCodexSkillMissingDescriptionHover/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/SessionsCodexSkillMissingDescriptionHover/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Light
#### chat/chatQuestionCarousel/MarkdownLinks/Dark
#### chat/chatQuestionCarousel/MarkdownLinks/DarkHighContrast
#### chat/chatQuestionCarousel/MarkdownLinks/Light
#### chat/chatQuestionCarousel/MarkdownLinks/LightHighContrast
#### chat/input/chatInput/CompactWithProviderIcon/Dark
#### chat/input/chatInput/CompactWithProviderIcon/Light
#### chat/input/chatInput/CopilotHarnessCompactPickers/Dark
#### chat/input/chatInput/CopilotHarnessCompactPickers/Light
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Dark
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Light
#### comments/commentTree/CommentTreeMetadataZoomed/Dark
#### comments/commentTree/CommentTreeMetadataZoomed/DarkHighContrast
#### comments/commentTree/CommentTreeMetadataZoomed/Light
#### comments/commentTree/CommentTreeMetadataZoomed/LightHighContrast
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Light
#### editor/injectedTextDecorations/ColorDecorators/Dark
#### editor/injectedTextDecorations/ColorDecorators/Light
#### editor/injectedTextDecorations/InlayHints/Dark
#### editor/injectedTextDecorations/InlayHints/Light
#### editor/injectedTextDecorations/InlineProgress/Dark
#### editor/injectedTextDecorations/InlineProgress/Light
#### editor/injectedTextDecorations/SelectedColorDecorator/Dark
#### editor/injectedTextDecorations/SelectedColorDecorator/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
#### editor/wordWrapIndicator/WordWrapIndicator/Dark
#### editor/wordWrapIndicator/WordWrapIndicator/DarkHighContrast
#### editor/wordWrapIndicator/WordWrapIndicator/Light
#### editor/wordWrapIndicator/WordWrapIndicatorDisabled/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorDisabled/Light
#### editor/wordWrapIndicator/WordWrapIndicatorFixedColumnBeyondViewport/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorFixedColumnBeyondViewport/Light
#### editor/wordWrapIndicator/WordWrapIndicatorVariableLineHeight/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorVariableLineHeight/Light
#### editor/wordWrapIndicator/WordWrapIndicatorViewportWrapping/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorViewportWrapping/Light
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Dark
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Light
#### sessions/chat/input/chatInput/ResponsiveModelResizeCycleMinimal/Dark
#### sessions/chat/input/chatInput/ResponsiveModelResizeCycleMinimal/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
#### sessions/chat/view/chatView/AssistantResponseBackground/Dark
#### sessions/chat/view/chatView/AssistantResponseBackground/Light
#### sessions/chat/view/chatView/AssistantResponsePlain/Dark
#### sessions/chat/view/chatView/AssistantResponsePlain/Light
#### sessions/chat/view/chatView/CheckpointControlsBackground/Dark
#### sessions/chat/view/chatView/CheckpointControlsBackground/Light
#### sessions/chat/view/chatView/RequestAttachmentBackground/Dark
#### sessions/chat/view/chatView/RequestAttachmentBackground/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
#### sessions/sessionsList/SessionsList_LightweightNewButton/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButton/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButton/Light
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Light
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Dark
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Light
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Dark
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Light
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Dark
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Light
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Dark
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/DarkHighContrast
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Light
Patch--- test/componentFixtures/blocks-ci-screenshots.md 2026-09-16 08:12:14.253189105 +0000
+++ /tmp/blocks-ci-updated.md 2026-09-16 08:27:00.305272136 +0000
@@ -40,7 +40,7 @@
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Light
-
+
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Dark
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #275176. This PR addresses no-op polling only; batching and incremental Markdown parsing are intentionally out of scope.
Validation