agentHost: Reconcile retained-child status after stale reads - #335979
Draft
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Draft
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Conversation
Capture task-status freshness when each RPC starts and drain invalidated reads through the existing single-flight scheduler. Guard completion application across resumption, cancellation and disposal, and add deterministic delayed-query regressions. Related to #335458; child execution identity remains a separate fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
added
vscode-build
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 12, 2026 21:47
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 12, 2026 21:48
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scheduler changes are internally consistent and covered by targeted deterministic regressions.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
What changed in this PR
Fixes stale retained-subagent status reconciliation while improving related diagnostics and regression coverage.
Changes:
- Reconciles invalidated status reads serially until reaching a stable revision.
- Stops reconciliation after cancellation or disposal.
- Adds deterministic race/lifecycle tests and richer E2E failure details.
| File | Description |
|---|---|
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Implements revision-aware reconciliation. |
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts |
Adds race, serialization, and lifecycle tests. |
src/vs/platform/agentHost/test/node/e2e/suites/subagentSuite.ts |
Expands retained-child diagnostics. |
src/vs/platform/agentHost/test/node/e2e/README.md |
Documents failure interpretation and coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Base:
|
Clear only the aborted root's active child ownership and usage through the existing silent completion cleanup before awaiting the SDK. Preserve stable routing and cancellation guards so late status replies cannot affect a reused child. Add abort/reuse accounting regressions and explicit initial/follow-up identities in retained-child fixtures. Keep the duplicate-child ledger and combined validation overlay out of this standalone change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 13, 2026 07:03
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The concurrency and cleanup changes are narrowly scoped and covered by comprehensive deterministic regressions.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
Dmitriy Vasyura (dmitrivMS)
marked this pull request as draft
September 15, 2026 08:04
auto-merge was automatically disabled
September 15, 2026 08:04
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix retained subagents staying active when a resume invalidates an in-flight task-status read.
Related to #335458. Duplicate-child execution identity is handled separately in #335989.
Validation
c77343648da0: 127 selected unit tests and 4 strict replays passed. Combined code is not included here.