Skip to content

Bump xterm to 6.1.0-beta.304 - #335582

Merged
Anthony Kim (anthonykim1) merged 2 commits into
mainfrom
anthonykim1/xtermSep10v2
Sep 10, 2026
Merged

Anthony Kim (anthonykim1) merged 2 commits into
mainfrom
anthonykim1/xtermSep10v2

Conversation

@anthonykim1

Copy link
Copy Markdown
Contributor
  • Update all @xterm/* dependencies to the publish generation built from c58ea363 across the root, remote/, and remote/web/ dependency sets (@xterm/xterm → beta.304, @xterm/headless and addon-clipboard → beta.303, addon-image/addon-ligatures/addon-progress/addon-search/addon-serialize/addon-unicode11 → beta.301, addon-webgl → beta.300).
  • Regenerate the corresponding lockfiles for all three dependency roots.
  • Advance the published xterm.js source from d3e32b34 to c58ea363.

Upstream changelog

  • xtermjs/xterm.js#5879 changes image storage to use the general-purpose ExtendedAttrs.payload field, avoiding conflicts with other extensions and reducing reliance on BufferLine internals.
  • The remaining commits in the range are supporting merge and follow-up fix commits for that change.

Version alignment note

All ten packages in this update are built from the same upstream commit, c58ea363. The differing -beta.N values are per-package publish counters and are expected to be unequal.

Verified: addon peer ranges (^6.1.0-beta.304) are satisfied by @xterm/xterm@6.1.0-beta.304, all three dependency trees resolve a single copy of each package with no nested duplicates, git diff --check passes, and npm run hygiene passes.

npm run typecheck-client was also attempted locally, but this worktree does not have the generated Electron and original-fs dependencies installed; CI will run the full compile and type checks.

Full upstream diff


Inspirations from:

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 10, 2026 22:28
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as ready for review September 10, 2026 22:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Dependency declarations and generated lockfile entries are complete, consistent across all three roots, and aligned with the referenced upstream change.

Review tier: Balanced
Findings: None

What changed in this PR

Updates xterm.js and its addons to the publish generation built from upstream commit c58ea363.

Changes:

  • Bumps all xterm dependencies consistently across desktop, remote, and remote web.
  • Regenerates lockfiles with matching versions, peer ranges, integrity hashes, and resolved artifacts.
File Description
package.json Updates root xterm dependencies.
package-lock.json Locks updated root packages.
remote/​package.json Updates remote xterm dependencies.
remote/​package-lock.json Locks updated remote packages.
remote/​web/​package.json Updates web-compatible xterm dependencies.
remote/​web/​package-lock.json Locks updated remote web packages.
Files not reviewed (2)
  • remote/package-lock.json: Generated file
  • remote/web/package-lock.json: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@anthonykim1 Anthony Kim (anthonykim1) added this to the 1.138.0 milestone Sep 10, 2026
@anthonykim1
Anthony Kim (anthonykim1) merged commit 8014e6a into main Sep 10, 2026
34 checks passed
@anthonykim1
Anthony Kim (anthonykim1) deleted the anthonykim1/xtermSep10v2 branch September 10, 2026 23:55
Abdon Morales (abdonmorales) pushed a commit to abdonmorales/vscode-utcs that referenced this pull request Sep 23, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 8014e6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants