[Perf] chat: avoid transferring local debug logs over IPC - #331735
Merged
Conversation
Keep local log and user-data resources as URI/size descriptors so the main process can stream them directly into the export. Bound unavoidable inline content for non-local resources to a shared 30 MiB budget.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Moves local debug-log packaging out of the renderer to reduce IPC and memory overhead.
Changes:
- Represents local logs as URI/size descriptors.
- Streams local files directly into native ZIP output.
- Caps non-local inline log content at 30 MiB.
Show a summary per file
| File | Description |
|---|---|
exportAgentHostDebugLogs.test.ts |
Tests local descriptors and inline limits. |
exportAgentHostDebugLogsService.ts |
Converts local descriptors for native ZIP streaming. |
exportAgentHostDebugLogsAction.ts |
Collects descriptors and enforces the shared inline budget. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
roblourens
marked this pull request as ready for review
August 20, 2026 01:28
roblourens
enabled auto-merge (squash)
August 20, 2026 01:28
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #331665.
What changed
Why
A fully rotated renderer/shared log setup can retain and serialize tens of MiB in the renderer before the native ZIP size check runs. Passing local resources avoids the renderer and IPC memory amplification while preserving inline support for genuinely non-local resources.
Validation
npm run transpile-client./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/exportAgentHostDebugLogs.test.ts(8 passing)(Written by Copilot)