Pause telemetry on metered connections - #331685
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Robo (@deepak1556)Matched files:
|
There was a problem hiding this comment.
Pull request overview
Pauses telemetry event submission when VS Code detects a metered connection.
Changes:
- Propagates initial metered state across Electron processes.
- Gates standard and custom-endpoint telemetry.
- Drops experiment-buffered events when flushing while metered.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/services/telemetry/electron-browser/telemetryService.ts |
Passes metered state to workbench telemetry. |
src/vs/platform/telemetry/test/browser/telemetryService.test.ts |
Tests dropping direct and buffered events. |
src/vs/platform/telemetry/node/customEndpointTelemetryService.ts |
Gates custom-endpoint telemetry. |
src/vs/platform/telemetry/common/telemetryService.ts |
Prevents buffered-event flushing while metered. |
src/vs/platform/meteredConnection/test/electron-browser/meteredConnectionService.test.ts |
Tests initial state propagation. |
src/vs/platform/meteredConnection/electron-browser/meteredConnectionService.ts |
Sends initial browser state to the main process. |
src/vs/code/electron-utility/sharedProcess/sharedProcessMain.ts |
Wires metered state into shared-process telemetry. |
src/vs/code/electron-main/app.ts |
Wires metered state into main-process telemetry. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Balanced
Pull request was converted to draft
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mohammad javad Dianat (dianatofficial)
left a comment
There was a problem hiding this comment.
LGTM! Code changes are clean and well-structured.
Fold #331685 into the native metered implementation. Wait for initial network state, pause queued 1DS batches and retries, suppress metered shutdown sends, and update running debugger telemetry children without waking idle ones. Drop known-metered events before experiment buffering. Default metered auto-detection to Insiders only, with no experiment override. Fixes #297362 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Superseded by #331897, which now includes these desktop telemetry fixes in 2f9e41f and includes The integration adapts the fixes to native Local validation passed: 81 focused tests, 15 telemetry compatibility tests, client type-check, and hygiene/ESLint. Additional Agent Host, CLI, and browser collectors are tracked separately in #336679. Closing this PR in favor of the consolidated implementation; the source branch is retained. |
|
The combined work has now been split for review. The replacement for this PR is #336922, stacked directly on the native metered service PR #331897. #336922 owns the telemetry implementation and the closing link for #297362; #331897 intentionally has no telemetry-metered coupling until that child is applied. This superseded PR remains closed and its branch is retained. |
Fixes #297362