Fix model context resolution#322256
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect “resolved model configuration” behavior in chat UI surfaces by ensuring schema defaults are consistently present (and used as fallbacks) and by improving how per-editor configuration is stored and propagated.
Changes:
- Update model-configuration resolution to always merge schema defaults, even when no stored/global config exists.
- Adjust per-editor configuration store behavior to mirror user changes to the profile-global configuration and to handle late model/provider registration.
- Align UI fallback behavior (context-usage widget + session-type resolution) with the corrected configuration semantics and add/adjust tests.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelConfigurationStore.test.ts | Updates test stubs for new ILanguageModelsService members used by the store. |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelConfigurationLogic.test.ts | Updates/extends tests to assert schema defaults are preserved during resolution. |
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatContextUsageWidget.ts | Adds schema-default fallback for displayed context window size to match picker semantics. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelConfigurationStore.ts | Adds cache invalidation + mirrors per-editor changes to profile-global config; refactors local write path. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelConfigurationLogic.ts | Ensures resolveModelConfiguration always merges schema defaults. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Prefers the actual session resource for determining session type once a session exists. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 2
bhavyaus
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.